Skip to content

Commit

Permalink
bootstrap: tweak verbosity settings
Browse files Browse the repository at this point in the history
Currently the verbosity settings are:
- 2: RUSTC-SHIM envvars get spammed on every invocation, O(30) lines
     cargo is passed -v which outputs CLI invocations, O(5) lines
- 3: cargo is passed -vv which outputs build script output, O(0-10) lines

This commit changes it to:

- 1: cargo is passed -v, O(5) lines
- 2: cargo is passed -vv, O(10) lines
- 3: RUSTC-SHIM envvars get spammed, O(30) lines
  • Loading branch information
infinity0 committed Oct 16, 2021
1 parent 7fbd4ce commit d78559a
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/bootstrap/bin/rustc.rs
Expand Up @@ -146,7 +146,7 @@ fn main() {
}

let is_test = args.iter().any(|a| a == "--test");
if verbose > 1 {
if verbose > 2 {
let rust_env_vars =
env::vars().filter(|(k, _)| k.starts_with("RUST") || k.starts_with("CARGO"));
let prefix = if is_test { "[RUSTC-SHIM] rustc --test" } else { "[RUSTC-SHIM] rustc" };
Expand Down
2 changes: 1 addition & 1 deletion src/bootstrap/bootstrap.py
Expand Up @@ -959,7 +959,7 @@ def build_bootstrap(self):
self.cargo()))
args = [self.cargo(), "build", "--manifest-path",
os.path.join(self.rust_root, "src/bootstrap/Cargo.toml")]
for _ in range(1, self.verbose):
for _ in range(0, self.verbose):
args.append("--verbose")
if self.use_locked_deps:
args.append("--locked")
Expand Down
2 changes: 1 addition & 1 deletion src/bootstrap/builder.rs
Expand Up @@ -1483,7 +1483,7 @@ impl<'a> Builder<'a> {
cargo.env("WINAPI_NO_BUNDLED_LIBRARIES", "1");
}

for _ in 1..self.verbosity {
for _ in 0..self.verbosity {
cargo.arg("-v");
}

Expand Down

0 comments on commit d78559a

Please sign in to comment.