Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
casting integer literal to float is unnecessary
- Loading branch information
rink1969
committed
Mar 14, 2019
1 parent
8fc0a73
commit d9dd008
Showing
10 changed files
with
219 additions
and
135 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,176 +1,194 @@ | ||
error: casting i32 to f32 causes a loss of precision (i32 is 32 bits wide, but f32's mantissa is only 23 bits wide) | ||
--> $DIR/cast.rs:11:5 | ||
--> $DIR/cast.rs:12:5 | ||
| | ||
LL | 1i32 as f32; | ||
| ^^^^^^^^^^^ | ||
LL | x0 as f32; | ||
| ^^^^^^^^^ | ||
| | ||
= note: `-D clippy::cast-precision-loss` implied by `-D warnings` | ||
|
||
error: casting i64 to f32 causes a loss of precision (i64 is 64 bits wide, but f32's mantissa is only 23 bits wide) | ||
--> $DIR/cast.rs:12:5 | ||
--> $DIR/cast.rs:14:5 | ||
| | ||
LL | 1i64 as f32; | ||
| ^^^^^^^^^^^ | ||
LL | x1 as f32; | ||
| ^^^^^^^^^ | ||
|
||
error: casting i64 to f64 causes a loss of precision (i64 is 64 bits wide, but f64's mantissa is only 52 bits wide) | ||
--> $DIR/cast.rs:13:5 | ||
--> $DIR/cast.rs:15:5 | ||
| | ||
LL | 1i64 as f64; | ||
| ^^^^^^^^^^^ | ||
LL | x1 as f64; | ||
| ^^^^^^^^^ | ||
|
||
error: casting u32 to f32 causes a loss of precision (u32 is 32 bits wide, but f32's mantissa is only 23 bits wide) | ||
--> $DIR/cast.rs:14:5 | ||
--> $DIR/cast.rs:17:5 | ||
| | ||
LL | 1u32 as f32; | ||
| ^^^^^^^^^^^ | ||
LL | x2 as f32; | ||
| ^^^^^^^^^ | ||
|
||
error: casting u64 to f32 causes a loss of precision (u64 is 64 bits wide, but f32's mantissa is only 23 bits wide) | ||
--> $DIR/cast.rs:15:5 | ||
--> $DIR/cast.rs:19:5 | ||
| | ||
LL | 1u64 as f32; | ||
| ^^^^^^^^^^^ | ||
LL | x3 as f32; | ||
| ^^^^^^^^^ | ||
|
||
error: casting u64 to f64 causes a loss of precision (u64 is 64 bits wide, but f64's mantissa is only 52 bits wide) | ||
--> $DIR/cast.rs:16:5 | ||
--> $DIR/cast.rs:20:5 | ||
| | ||
LL | 1u64 as f64; | ||
| ^^^^^^^^^^^ | ||
LL | x3 as f64; | ||
| ^^^^^^^^^ | ||
|
||
error: casting f32 to i32 may truncate the value | ||
--> $DIR/cast.rs:18:5 | ||
--> $DIR/cast.rs:22:5 | ||
| | ||
LL | 1f32 as i32; | ||
| ^^^^^^^^^^^ | ||
| | ||
= note: `-D clippy::cast-possible-truncation` implied by `-D warnings` | ||
|
||
error: casting f32 to u32 may truncate the value | ||
--> $DIR/cast.rs:19:5 | ||
--> $DIR/cast.rs:23:5 | ||
| | ||
LL | 1f32 as u32; | ||
| ^^^^^^^^^^^ | ||
|
||
error: casting f32 to u32 may lose the sign of the value | ||
--> $DIR/cast.rs:19:5 | ||
--> $DIR/cast.rs:23:5 | ||
| | ||
LL | 1f32 as u32; | ||
| ^^^^^^^^^^^ | ||
| | ||
= note: `-D clippy::cast-sign-loss` implied by `-D warnings` | ||
|
||
error: casting f64 to f32 may truncate the value | ||
--> $DIR/cast.rs:20:5 | ||
--> $DIR/cast.rs:24:5 | ||
| | ||
LL | 1f64 as f32; | ||
| ^^^^^^^^^^^ | ||
|
||
error: casting i32 to i8 may truncate the value | ||
--> $DIR/cast.rs:21:5 | ||
--> $DIR/cast.rs:25:5 | ||
| | ||
LL | 1i32 as i8; | ||
| ^^^^^^^^^^ | ||
|
||
error: casting i32 to u8 may truncate the value | ||
--> $DIR/cast.rs:22:5 | ||
--> $DIR/cast.rs:26:5 | ||
| | ||
LL | 1i32 as u8; | ||
| ^^^^^^^^^^ | ||
|
||
error: casting f64 to isize may truncate the value | ||
--> $DIR/cast.rs:23:5 | ||
--> $DIR/cast.rs:27:5 | ||
| | ||
LL | 1f64 as isize; | ||
| ^^^^^^^^^^^^^ | ||
|
||
error: casting f64 to usize may truncate the value | ||
--> $DIR/cast.rs:24:5 | ||
--> $DIR/cast.rs:28:5 | ||
| | ||
LL | 1f64 as usize; | ||
| ^^^^^^^^^^^^^ | ||
|
||
error: casting f64 to usize may lose the sign of the value | ||
--> $DIR/cast.rs:24:5 | ||
--> $DIR/cast.rs:28:5 | ||
| | ||
LL | 1f64 as usize; | ||
| ^^^^^^^^^^^^^ | ||
|
||
error: casting u8 to i8 may wrap around the value | ||
--> $DIR/cast.rs:26:5 | ||
--> $DIR/cast.rs:30:5 | ||
| | ||
LL | 1u8 as i8; | ||
| ^^^^^^^^^ | ||
| | ||
= note: `-D clippy::cast-possible-wrap` implied by `-D warnings` | ||
|
||
error: casting u16 to i16 may wrap around the value | ||
--> $DIR/cast.rs:27:5 | ||
--> $DIR/cast.rs:31:5 | ||
| | ||
LL | 1u16 as i16; | ||
| ^^^^^^^^^^^ | ||
|
||
error: casting u32 to i32 may wrap around the value | ||
--> $DIR/cast.rs:28:5 | ||
--> $DIR/cast.rs:32:5 | ||
| | ||
LL | 1u32 as i32; | ||
| ^^^^^^^^^^^ | ||
|
||
error: casting u64 to i64 may wrap around the value | ||
--> $DIR/cast.rs:29:5 | ||
--> $DIR/cast.rs:33:5 | ||
| | ||
LL | 1u64 as i64; | ||
| ^^^^^^^^^^^ | ||
|
||
error: casting usize to isize may wrap around the value | ||
--> $DIR/cast.rs:30:5 | ||
--> $DIR/cast.rs:34:5 | ||
| | ||
LL | 1usize as isize; | ||
| ^^^^^^^^^^^^^^^ | ||
|
||
error: casting f32 to f64 may become silently lossy if types change | ||
--> $DIR/cast.rs:32:5 | ||
--> $DIR/cast.rs:36:5 | ||
| | ||
LL | 1.0f32 as f64; | ||
| ^^^^^^^^^^^^^ help: try: `f64::from(1.0f32)` | ||
| | ||
= note: `-D clippy::cast-lossless` implied by `-D warnings` | ||
|
||
error: casting u8 to u16 may become silently lossy if types change | ||
--> $DIR/cast.rs:34:5 | ||
--> $DIR/cast.rs:38:5 | ||
| | ||
LL | (1u8 + 1u8) as u16; | ||
| ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(1u8 + 1u8)` | ||
|
||
error: casting i32 to u32 may lose the sign of the value | ||
--> $DIR/cast.rs:37:5 | ||
--> $DIR/cast.rs:41:5 | ||
| | ||
LL | -1i32 as u32; | ||
| ^^^^^^^^^^^^ | ||
|
||
error: casting isize to usize may lose the sign of the value | ||
--> $DIR/cast.rs:39:5 | ||
--> $DIR/cast.rs:43:5 | ||
| | ||
LL | -1isize as usize; | ||
| ^^^^^^^^^^^^^^^^ | ||
|
||
error: casting to the same type is unnecessary (`i32` -> `i32`) | ||
--> $DIR/cast.rs:48:5 | ||
--> $DIR/cast.rs:52:5 | ||
| | ||
LL | 1i32 as i32; | ||
| ^^^^^^^^^^^ | ||
| | ||
= note: `-D clippy::unnecessary-cast` implied by `-D warnings` | ||
|
||
error: casting to the same type is unnecessary (`f32` -> `f32`) | ||
--> $DIR/cast.rs:49:5 | ||
--> $DIR/cast.rs:53:5 | ||
| | ||
LL | 1f32 as f32; | ||
| ^^^^^^^^^^^ | ||
|
||
error: casting to the same type is unnecessary (`bool` -> `bool`) | ||
--> $DIR/cast.rs:50:5 | ||
--> $DIR/cast.rs:54:5 | ||
| | ||
LL | false as bool; | ||
| ^^^^^^^^^^^^^ | ||
|
||
error: aborting due to 27 previous errors | ||
error: casting integer literal to f32 is unnecessary | ||
--> $DIR/cast.rs:57:5 | ||
| | ||
LL | 100 as f32; | ||
| ^^^^^^^^^^ help: try: `100_f32` | ||
|
||
error: casting integer literal to f64 is unnecessary | ||
--> $DIR/cast.rs:58:5 | ||
| | ||
LL | 100 as f64; | ||
| ^^^^^^^^^^ help: try: `100_f64` | ||
|
||
error: casting integer literal to f64 is unnecessary | ||
--> $DIR/cast.rs:59:5 | ||
| | ||
LL | 100_i32 as f64; | ||
| ^^^^^^^^^^^^^^ help: try: `100_f64` | ||
|
||
error: aborting due to 30 previous errors | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.