Skip to content

Commit

Permalink
Fix merge fallout
Browse files Browse the repository at this point in the history
  • Loading branch information
James Miller committed Jun 22, 2013
1 parent fb6dc95 commit e3ef750
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 9 deletions.
1 change: 0 additions & 1 deletion src/librustc/middle/trans/cabi.rs
Expand Up @@ -92,7 +92,6 @@ impl FnType {

pub fn build_shim_ret(&self, bcx: block, arg_tys: &[Type], ret_def: bool,
llargbundle: ValueRef, llretval: ValueRef) {
for vec::eachi(self.attrs) |i, a| {
for self.attrs.iter().enumerate().advance |(i, a)| {
match *a {
option::Some(attr) => {
Expand Down
2 changes: 1 addition & 1 deletion src/librustc/middle/trans/cabi_x86.rs
Expand Up @@ -64,7 +64,7 @@ impl ABIInfo for X86_ABIInfo {
} else if !ret_def {
ret_ty = LLVMType {
cast: false,
ty: T_void()
ty: Type::void()
};
}

Expand Down
7 changes: 3 additions & 4 deletions src/librustc/middle/trans/closure.rs
Expand Up @@ -300,12 +300,11 @@ pub fn build_closure(bcx0: block,
let ret_true = match bcx.fcx.loop_ret {
Some((_, retptr)) => retptr,
None => match bcx.fcx.llretptr {
None => C_null(T_ptr(T_nil())),
Some(retptr) => retptr,
None => C_null(Type::nil().ptr_to()),
Some(retptr) => PointerCast(bcx, retptr, Type::nil().ptr_to()),
}
};
let ret_casted = PointerCast(bcx, ret_true, Type::nil().ptr_to());
let ret_datum = Datum {val: ret_casted, ty: ty::mk_nil(),
let ret_datum = Datum {val: ret_true, ty: ty::mk_nil(),
mode: ByRef(ZeroMem)};
env_vals.push(EnvValue {action: EnvRef,
datum: ret_datum});
Expand Down
1 change: 0 additions & 1 deletion src/librustc/middle/trans/glue.rs
Expand Up @@ -370,7 +370,6 @@ pub fn make_visit_glue(bcx: block, v: ValueRef, t: ty::t) {
pub fn make_free_glue(bcx: block, v: ValueRef, t: ty::t) {
// NB: v0 is an *alias* of type t here, not a direct value.
let _icx = push_ctxt("make_free_glue");
let ccx = bcx.ccx();
let bcx = match ty::get(t).sty {
ty::ty_box(body_mt) => {
let v = Load(bcx, v);
Expand Down
1 change: 0 additions & 1 deletion src/librustc/middle/trans/monomorphize.rs
Expand Up @@ -61,7 +61,6 @@ pub fn monomorphic_fn(ccx: @mut CrateContext,

assert!(real_substs.tps.iter().all(|t| !ty::type_needs_infer(*t)));
let _icx = push_ctxt("monomorphic_fn");
let _icx = ccx.insn_ctxt("monomorphic_fn");
let mut must_cast = false;
let substs = vec::map(real_substs.tps, |t| {
match normalize_for_monomorphization(ccx.tcx, *t) {
Expand Down
2 changes: 1 addition & 1 deletion src/librustc/middle/trans/type_of.rs
Expand Up @@ -339,5 +339,5 @@ pub fn llvm_type_name(cx: &CrateContext,

pub fn type_of_dtor(ccx: &mut CrateContext, self_ty: ty::t) -> Type {
let self_ty = type_of(ccx, self_ty).ptr_to();
Type::func([self_ty], Type::void())
Type::func([self_ty], &Type::void())
}

5 comments on commit e3ef750

@bors
Copy link
Contributor

@bors bors commented on e3ef750 Jun 22, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from graydon
at Aatch@e3ef750

@bors
Copy link
Contributor

@bors bors commented on e3ef750 Jun 22, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging Aatch/rust/trans-refactor-pt2 = e3ef750 into auto

@bors
Copy link
Contributor

@bors bors commented on e3ef750 Jun 22, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aatch/rust/trans-refactor-pt2 = e3ef750 merged ok, testing candidate = dc4560d

@bors
Copy link
Contributor

@bors bors commented on e3ef750 Jun 22, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = dc4560d

Please sign in to comment.