Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Apply lint attrs to individual "use" declarations
Fixes #10534
- Loading branch information
Showing
3 changed files
with
46 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
src/test/compile-fail/lint-directives-on-use-items-issue-10534.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
#![deny(unused_imports)] | ||
|
||
// The aim of this test is to ensure that deny/allow/warn directives | ||
// are applied to individual "use" statements instead of silently | ||
// ignored. | ||
|
||
#[allow(dead_code)] | ||
mod a { pub static x: int = 3; pub static y: int = 4; } | ||
|
||
mod b { | ||
use a::x; //~ ERROR: unused import | ||
#[allow(unused_imports)] | ||
use a::y; // no error here | ||
} | ||
|
||
#[allow(unused_imports)] | ||
mod c { | ||
use a::x; | ||
#[deny(unused_imports)] | ||
use a::y; //~ ERROR: unused import | ||
} | ||
|
||
fn main() {} |
e72d49a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at dcrewi@e72d49a
e72d49a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging dcrewi/rust/lint-directives-on-use-items = e72d49a into auto
e72d49a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dcrewi/rust/lint-directives-on-use-items = e72d49a merged ok, testing candidate = 5ea0509
e72d49a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/5440
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/5436
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/4529
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/4542
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/5538
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/4626
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/4634
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/5540
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/4625
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/4631
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/4693
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2425
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/5534
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/4629
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/4644
e72d49a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 5ea0509