Skip to content

Commit

Permalink
Add flag to the ListFormatting struct for nested imports
Browse files Browse the repository at this point in the history
  • Loading branch information
jrobsonchase committed Jun 19, 2018
1 parent 2077855 commit ee5ff2d
Show file tree
Hide file tree
Showing 12 changed files with 20 additions and 1 deletion.
1 change: 1 addition & 0 deletions src/attr.rs
Expand Up @@ -247,6 +247,7 @@ impl Rewrite for ast::MetaItem {
shape: item_shape,
ends_with_newline: false,
preserve_newline: false,
nested: false,
config: context.config,
};
let item_str = write_list(&item_vec, &fmt)?;
Expand Down
1 change: 1 addition & 0 deletions src/closures.rs
Expand Up @@ -260,6 +260,7 @@ fn rewrite_closure_fn_decl(
shape: arg_shape,
ends_with_newline: false,
preserve_newline: true,
nested: false,
config: context.config,
};
let list_str = write_list(&item_vec, &fmt)?;
Expand Down
2 changes: 2 additions & 0 deletions src/expr.rs
Expand Up @@ -1338,6 +1338,7 @@ pub fn rewrite_multiple_patterns(
shape,
ends_with_newline: false,
preserve_newline: false,
nested: false,
config: context.config,
};
write_list(&items, &fmt)
Expand Down Expand Up @@ -1902,6 +1903,7 @@ where
shape,
ends_with_newline: false,
preserve_newline: false,
nested: false,
config: context.config,
};
let list_str = write_list(&item_vec, &fmt)?;
Expand Down
1 change: 1 addition & 0 deletions src/imports.rs
Expand Up @@ -727,6 +727,7 @@ fn rewrite_nested_use_tree(
shape: nested_shape,
ends_with_newline,
preserve_newline: true,
nested: has_nested_list,
config: context.config,
};

Expand Down
4 changes: 4 additions & 0 deletions src/items.rs
Expand Up @@ -533,6 +533,7 @@ impl<'a> FmtVisitor<'a> {
shape,
ends_with_newline: true,
preserve_newline: true,
nested: false,
config: self.config,
};

Expand Down Expand Up @@ -2307,6 +2308,7 @@ fn rewrite_args(
shape: Shape::legacy(budget, indent),
ends_with_newline: tactic.ends_with_newline(context.config.indent_style()),
preserve_newline: true,
nested: false,
config: context.config,
};

Expand Down Expand Up @@ -2494,6 +2496,7 @@ fn rewrite_where_clause_rfc_style(
shape: clause_shape,
ends_with_newline: true,
preserve_newline: true,
nested: false,
config: context.config,
};
let preds_str = write_list(&items.collect::<Vec<_>>(), &fmt)?;
Expand Down Expand Up @@ -2607,6 +2610,7 @@ fn rewrite_where_clause(
shape: Shape::legacy(budget, offset),
ends_with_newline: tactic.ends_with_newline(context.config.indent_style()),
preserve_newline: true,
nested: false,
config: context.config,
};
let preds_str = write_list(&item_vec, &fmt)?;
Expand Down
6 changes: 5 additions & 1 deletion src/lists.rs
Expand Up @@ -34,6 +34,8 @@ pub struct ListFormatting<'a> {
pub ends_with_newline: bool,
// Remove newlines between list elements for expressions.
pub preserve_newline: bool,
// Nested import lists get some special handling for the "Mixed" list type
pub nested: bool,
pub config: &'a Config,
}

Expand Down Expand Up @@ -288,7 +290,8 @@ where
// 1 is space between separator and item.
if (line_len > 0 && line_len + 1 + total_width > formatting.shape.width)
|| prev_item_had_post_comment
|| (prev_item_is_nested_import || (!first && inner_item.contains("::")))
|| (formatting.nested
&& (prev_item_is_nested_import || (!first && inner_item.contains("::"))))
{
result.push('\n');
result.push_str(indent_str);
Expand Down Expand Up @@ -824,6 +827,7 @@ pub fn struct_lit_formatting<'a>(
shape,
ends_with_newline,
preserve_newline: true,
nested: false,
config: context.config,
}
}
1 change: 1 addition & 0 deletions src/macros.rs
Expand Up @@ -399,6 +399,7 @@ pub fn rewrite_macro_def(
shape: arm_shape,
ends_with_newline: true,
preserve_newline: true,
nested: false,
config: context.config,
};

Expand Down
1 change: 1 addition & 0 deletions src/matches.rs
Expand Up @@ -224,6 +224,7 @@ fn rewrite_match_arms(
shape: arm_shape,
ends_with_newline: true,
preserve_newline: true,
nested: false,
config: context.config,
};

Expand Down
1 change: 1 addition & 0 deletions src/overflow.rs
Expand Up @@ -388,6 +388,7 @@ impl<'a, T: 'a + Rewrite + ToExpr + Spanned> Context<'a, T> {
_ => false,
},
preserve_newline: false,
nested: false,
config: self.context.config,
};

Expand Down
1 change: 1 addition & 0 deletions src/reorder.rs
Expand Up @@ -77,6 +77,7 @@ fn wrap_reorderable_items(
shape,
ends_with_newline: true,
preserve_newline: false,
nested: false,
config: context.config,
};

Expand Down
1 change: 1 addition & 0 deletions src/types.rs
Expand Up @@ -366,6 +366,7 @@ where
shape: list_shape,
ends_with_newline: tactic.ends_with_newline(context.config.indent_style()),
preserve_newline: true,
nested: false,
config: context.config,
};

Expand Down
1 change: 1 addition & 0 deletions src/vertical.rs
Expand Up @@ -252,6 +252,7 @@ fn rewrite_aligned_items_inner<T: AlignedItem>(
shape: item_shape,
ends_with_newline: true,
preserve_newline: true,
nested: false,
config: context.config,
};
write_list(&items, &fmt)
Expand Down

0 comments on commit ee5ff2d

Please sign in to comment.