Skip to content

Commit

Permalink
Add test for issue 29124
Browse files Browse the repository at this point in the history
  • Loading branch information
Daniel J Rollins authored and Manishearth committed Mar 19, 2016
1 parent 5e3b36c commit fa0efa6
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/librustc_typeck/check/method/suggest.rs
Expand Up @@ -134,7 +134,7 @@ pub fn report_error<'a, 'tcx>(fcx: &FnCtxt<'a, 'tcx>,
if let Ok (expr_string) = cx.sess.codemap().span_to_snippet(expr.span) {
err.fileline_note(
expr.span,
&format!("{} is a function, perhaps you wish to call it?",
&format!("{} is a function, perhaps you wish to call it",
expr_string));
err.span_suggestion(expr.span,
"try calling the base function:",
Expand Down
31 changes: 31 additions & 0 deletions src/test/compile-fail/issue-29124.rs
@@ -0,0 +1,31 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

struct ret;
struct obj;

impl obj {
fn func() -> ret {
ret
}
}

fn func() -> ret {
ret
}

fn main() {
obj::func.x();
//~^ ERROR no method named `x` found for type `fn() -> ret {obj::func}` in the current scope
//~^^ NOTE obj::func is a function, perhaps you wish to call it
func.x();
//~^ ERROR no method named `x` found for type `fn() -> ret {func}` in the current scope
//~^^ NOTE func is a function, perhaps you wish to call it
}

0 comments on commit fa0efa6

Please sign in to comment.