Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DWARF version is clamped to at most 3 #13611

Closed
alexcrichton opened this issue Apr 18, 2014 · 2 comments
Closed

DWARF version is clamped to at most 3 #13611

alexcrichton opened this issue Apr 18, 2014 · 2 comments
Labels
A-codegen Area: Code generation A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.)

Comments

@alexcrichton
Copy link
Member

Looks like LLVM is capabable of and is currently emitting dwarf version 4 (after upgrading LLVM to the current master). Our bots don't have a gdb which understands this version of dwarf (they're all on gdb 7.4), but gdb 7.6 does indeed understand this version.

For now I'm going to clamp the emitted version to 3 for all platforms but mac (which is on version 2), but we should in theory do something more graceful.

cc @michaelwoerister
cc #13513
alexcrichton added a commit to alexcrichton/rust that referenced this issue Apr 18, 2014
@alexcrichton
debuginfo: Clamp the maximum dwarf version to 3
426d701 
This is a consequence of rust-lang#13611 and our bots running a "fairly old" gdb which
doesn't understand the newer versions of dwarf.
@michaelwoerister
Copy link
Member

I don't think that this will be an actual issue anytime soon, as we don't use anything DWARF 4 specific, as far as I know.

@thestinger
Copy link
Contributor

I think DWARF 4 makes the debug information smaller, so it would be nice to get the bots upgraded to use it eventually.

@thestinger thestinger mentioned this issue Sep 18, 2014
Closed
bors added a commit that referenced this issue Sep 18, 2014
@bors
auto merge of #17364 : thestinger/rust/debuginfo, r=pnkfelix
d485e87 
Closes #13611
bors added a commit to rust-lang-ci/rust that referenced this issue Jan 9, 2023
@bors
Auto merge of rust-lang#13611 - yue4u:fix/completion-after-colon, r=y…
34e2bc6 
…ue4u

fix: filter unnecessary completions after colon

close rust-lang#13597
related: rust-lang#10173

This PR also happens to fix two extra issues:

1. The test case in https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-completion/src/tests/attribute.rs#L778-L801 was never triggered in previous behavior.

after:

https://user-images.githubusercontent.com/26110087/201476995-56adf955-0fa7-4f75-ab32-28a8e6cb9504.mp4

<del>
2. completions were triggered even in invalid paths, like

```rust
fn main() {
    core:::::$0
}
```

```rust
#[:::::$0]
struct X;
```

</del>

only `:::` is excluded as discussed in rust-lang/rust-analyzer#13611 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-codegen Area: Code generation A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stop clamping the DWARF version to 3 on Linux
3 participants
@alexcrichton @thestinger @michaelwoerister