Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to compile in OS X with a manually compiled GCC #4783

Closed
lifthrasiir opened this issue Feb 4, 2013 · 5 comments
Closed

Failed to compile in OS X with a manually compiled GCC #4783

lifthrasiir opened this issue Feb 4, 2013 · 5 comments

Comments

@lifthrasiir
Copy link
Contributor

Compiling 2372d2c in OS X 10.7.5 yielded the following error:

$ make
[snip]
  CC(target) [...]/rt/x86_64-apple-darwin/libuv/Release/obj.target/uv/src/libuv/src/uv-common.o
gcc: error: unrecognized command line option ‘-Wnewline-eof’
make[1]: *** [...]/rt/x86_64-apple-darwin/libuv/Release/obj.target/uv/src/libuv/src/uv-common.o] Error 1
make: *** [rt/x86_64-apple-darwin/libuv/Release/libuv.a] Error 2
make: *** Waiting for unfinished jobs....

-Wnewline-eof is only supported by Apple's version of GCC, and a manually compiled GCC (notably, Homebrew's GCC 4.7.0 which I use) does not have it. This can be ultimately traced back to a libuv's problem (node had a similar issue).

@brson
Copy link
Contributor

brson commented Feb 5, 2013

Thank you for tracking down the node bug.

@brson
Copy link
Contributor

brson commented Feb 5, 2013

FWIW, we are in the middle of upgrading uv so this aspect of the build is going to be changing. I suggest we revisit then. Putting on the 0.6 issue list.

@cooljeanius
Copy link

MacPorts applies the following patch to deal with this: https://trac.macports.org/browser/users/larryv/dports/lang/rust/files/patch-non_apple_gcc.diff?rev=104024

@pcwalton
Copy link
Contributor

uv has been upgraded, please try again.

@lifthrasiir
Copy link
Contributor Author

@pcwalton I've confirmed that the recent master succeeds to compile from the initial git clone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants