Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmarks to std::path #9694

Closed
emberian opened this issue Oct 3, 2013 · 3 comments
Closed

Add benchmarks to std::path #9694

emberian opened this issue Oct 3, 2013 · 3 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. I-slow Issue: Problems and improvements with respect to performance of generated code.

Comments

@emberian
Copy link
Member

emberian commented Oct 3, 2013

After #9655 lands.
@owaspjocur
Copy link

I would like to work on this, any extra info will be great

@g3xzh g3xzh mentioned this issue Dec 25, 2013
Merged
bors added a commit that referenced this issue Jan 1, 2014
@bors
auto merge of #11137 : g3xzh/rust/benchm, r=cmr
02cec05 
Benchmark testing `is_ancestor_of` and `pop`

ref: #9694
@mrshu
Copy link
Contributor

mrshu commented Feb 9, 2014

@cmr I am wondering if what #11137 introduced is enough or would you like to add some more benchmarks?

It seems that this issue is pretty much resolved if the former is true.

@emberian
Copy link
Member Author

emberian commented Feb 9, 2014

Yeah.

@emberian emberian closed this as completed Feb 9, 2014
bors added a commit to rust-lang-ci/rust that referenced this issue Jan 8, 2024
@bors
Auto merge of rust-lang#15933 - 71:inherent-items-in-docs, r=Veykril
c3c07c6 
feat: resolve inherent and implemented associated items in docs

This partially fixes rust-lang#9694.

Supported:
- Trait methods and constants.
  * Due to resolution differences pointed out during the review of the PR, trait associated types are _not_ supported.
- Inherent methods, constants and associated types.
  * Inherent associated types are a [nightly feature](rust-lang#8995), and are supported with no additional work in this PR.

Screenshot of VS Code running with the change:

<img width="513" alt="image" src="https://github.com/rust-lang/rust-analyzer/assets/7189784/c37ed8b7-b572-4684-8e81-2a817b0027c4">

You can see that the items are resolved (excl. trait associated types) since they are semantically highlighted in the doc comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. I-slow Issue: Problems and improvements with respect to performance of generated code.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mrshu @emberian @owaspjocur