Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove linked failure from the runtime #10603

Merged
merged 1 commit into from
Nov 25, 2013

Conversation

alexcrichton
Copy link
Member

The reasons for doing this are:

  • The model on which linked failure is based is inherently complex
  • The implementation is also very complex, and there are few remaining who
    fully understand the implementation
  • There are existing race conditions in the core context switching function of
    the scheduler, and possibly others.
  • It's unclear whether this model of linked failure maps well to a 1:1 threading
    model

Linked failure is often a desired aspect of tasks, but we would like to take a
much more conservative approach in re-implementing linked failure if at all.

Closes #8674
Closes #8318
Closes #8863

@alexcrichton
Copy link
Member Author

r? @brson

@pcwalton
Copy link
Contributor

+1

The reasons for doing this are:

* The model on which linked failure is based is inherently complex
* The implementation is also very complex, and there are few remaining who
  fully understand the implementation
* There are existing race conditions in the core context switching function of
  the scheduler, and possibly others.
* It's unclear whether this model of linked failure maps well to a 1:1 threading
  model

Linked failure is often a desired aspect of tasks, but we would like to take a
much more conservative approach in re-implementing linked failure if at all.

Closes rust-lang#8674
Closes rust-lang#8318
Closes rust-lang#8863
bors added a commit that referenced this pull request Nov 25, 2013
The reasons for doing this are:

* The model on which linked failure is based is inherently complex
* The implementation is also very complex, and there are few remaining who
  fully understand the implementation
* There are existing race conditions in the core context switching function of
  the scheduler, and possibly others.
* It's unclear whether this model of linked failure maps well to a 1:1 threading
  model

Linked failure is often a desired aspect of tasks, but we would like to take a
much more conservative approach in re-implementing linked failure if at all.

Closes #8674
Closes #8318
Closes #8863
@bors bors closed this Nov 25, 2013
@bors bors merged commit acca9e3 into rust-lang:master Nov 25, 2013
@alexcrichton alexcrichton deleted the no-linked-failure branch November 25, 2013 09:42
zargony added a commit to zargony/fuse-rs that referenced this pull request Nov 25, 2013
ehsanul added a commit to ehsanul/rust-http that referenced this pull request Nov 26, 2013
spawn_with and spawn_supervised have been removed in this pull request: rust-lang/rust#10603
flip1995 pushed a commit to flip1995/rust that referenced this pull request Apr 23, 2023
Fix false positives and false negatives in `octal_escapes`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants