Remove @[] #11974
Merged
Remove @[] #11974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compiler and use it for attributes
|
r? @pcwalton @alexcrichton (or anyone) (github is showing the commits out of order: the "Fix |
Seems to have been replaced by ExprVstore.
Various functions can now be made specific to ~[], or just non-managed vectors.
bors
added a commit
that referenced
this pull request
Feb 1, 2014
This removes @[] from the parser as well as much of the handling of it (and `@str`) from the compiler as I can find. I've just rebased @pcwalton's (already reviewed) `@str` removal (and fixed the problems in a separate commit); the only new work is the trailing commits with my authorship. Closes #11967
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 28, 2023
[`redundant_pattern_matching`]: lint `if let true`, `while let true`, `matches!(.., true)` Closes rust-lang#11917 This could also lint e.g. `if let (true, true, false) = (a, b, c)` and suggest `if a && b && c`, but that's a change in semantics (going from eager to lazy, so I just left it out for now. Could be a future improvement. changelog: [`redundant_pattern_matching`]: lint `if let true`, `while let true`, `matches!(.., true)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes @[] from the parser as well as much of the handling of it (and
@str) from the compiler as I can find.I've just rebased @pcwalton's (already reviewed)
@strremoval (and fixed the problems in a separate commit); the only new work is the trailing commits with my authorship.Closes #11967