Fix PartialEq documentation with regards to floats #14733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm also a bit worried that |
It is in fact the case that `NaN != NaN`. The true relations for compareQuietNotEqual are LT, GT *and* UN. I also rephrased the docs for PartialOrd since floats are not the only types which are not totally ordered.
I can't think of any sane cases where this restriction would not hold, and the standard library seems to assume it pretty much everywhere.
bors
added a commit
that referenced
this pull request
Jun 8, 2014
It is in fact the case that `NaN != NaN`. The true relations for compareQuietNotEqual are LT, GT *and* UN. I also rephrased the docs for PartialOrd since floats are not the only types which are not totally ordered.
|
cc #12517 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
Make line-index a lib, use nohash_hasher These seem like they are not specific to rust-analyzer and could be pulled out to their own libraries. So I did. azdavis/millet#31
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
Fix libs publish branch filter line-index didn't actually get published from rust-lang#14733, probably because the branch filter was for main but the main branch is called master here. This fixes the workflow file I also tweaked the libs readme mostly just so the paths filter would pick up the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is in fact the case that
NaN != NaN. The true relations forcompareQuietNotEqual are LT, GT and UN.
I also rephrased the docs for PartialOrd since floats are not the only
types which are not totally ordered.