-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please provide a new release #1019
Comments
ping |
Yeah, we will do it soon |
@sylvestre, any updates on the new release? |
This comment was marked as spam.
This comment was marked as spam.
@sylvestre, @milahu, any update on new releases? Anything blocking it that someone else could work? From an outsider's perspective the project has entirely given up doing new releases, since it's been over a year. |
Hey David, I'm currently chipping away at the backlog of open PRs to see what can be landed before the next release.
Mostly reviews, there's a few thousands of lines of changed code that needs to be looked through. I'm getting up-to-speed on the project as well. However, something that would be sweet is if we could get the dependencies updated, as it's been a hot minute. There were some patches doing so from a year ago, but if that could be done I'd be pretty happy. While we're at it, tackling modern compiler warnings and clippy lints will be important as well. |
@mitchhentges, thanks for the response! Happy to hear it's being worked on. I haven't built the project and have no Rust experience, but if you point me in the direction of specific PRs for dependencies, or issues for modern compiler warnings, I could take a look when I get a chance. I'm mainly itching for a release as I've run into #1098 several times and it might be fixed in |
I encourage you not to hold back releases for "one more little thing", especially for not for trivial code cleanup. I've been waiting on a release for around a year now. I don't care about Clippy warnings. |
@Be-ing please avoid such comments I've been waiting on a release for around a year now. I don't care about Clippy warnings. |
Fixing clippy warnings isn't adding anything for users. |
I disagree and please stop bikeshedding. |
This comment was marked as spam.
This comment was marked as spam.
I explained in the first comment that I already setup caching of the sccache build. But that's not a good solution; any time the cache misses, there's a 10 minute cost of rebuilding sccache which negates the benefit of using sccache for that build. Moreover, I just shouldn't need to do that in the first place. |
This comment was marked as spam.
This comment was marked as spam.
Please stop asking downstream users to come up with technical workarounds for your nontechnical problem. There is no need to review every open PR, fix every warning, or update every dependency to publish a new release. If you think there is, that's entirely self-imposed. Version numbers are cheap and releases don't need to solve everything at once. Meanwhile bug fixes from a year ago still have not been released. |
I am locking this thread. It is becoming useless. |
I'd like to add a little more perspective as well here, if it helps things.
Heh, it is an indirect benefit. Either way, this is a red herring: the real blocker isn't clippy warnings, it's that I'm getting up-to-speed with the project. Sure, there's a few commits that are sitting in Keep in mind that it isn't specifically clippy warnings that are blocking the release - I raised this work as something that the community could potentially contribute assistance with while I tackle the other blockers.
True, one option that exists here is to push out a release based on what's in By addressing PRs, catching up some issues, and doing some local work, I can build my mental model of the project, which will enable making more confident decisions around releases. |
Update:
We're probably still a couple weeks out, as I'll be away this upcoming week. But, we're getting close. Have a good weekend all 🍻 |
We'll probably see |
An issue has crept up during benchmarking, and I'm away tomorrow, so the release will happen next week at the earliest. |
Amazing, bravo! |
#962 was merged 3 months ago and is not yet included in a release. Because of this, Mixxx CI has to build sccache from source which takes 10 minutes. It is caching the sccache binary for subsequent runs, but the first run of each branch has this 10 minute penalty. This could be avoided if we could install sccache from Chocolatey, which requires a new release.
The text was updated successfully, but these errors were encountered: