Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: use CXX_COMPILER_LAUNCHER instead of RULE_LAUNCH_COMPILE #4098

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Jul 11, 2021

This allows for removing the hack for RULE_LAUNCH_COMPILE with
sccache.
https://gitlab.kitware.com/cmake/cmake/-/issues/22405

@github-actions github-actions bot added the build label Jul 11, 2021
@coveralls
Copy link

coveralls commented Jul 11, 2021

Pull Request Test Coverage Report for Build 1020536608

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 28.627%

Files with Coverage Reduction New Missed Lines %
src/engine/readaheadmanager.cpp 2 88.79%
src/engine/cachingreader/cachingreader.cpp 9 71.38%
Totals Coverage Status
Change from base Build 1019395588: -0.01%
Covered Lines: 20088
Relevant Lines: 70172

💛 - Coveralls

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, it still works here on Ubuntu. Judged from the Windows build time running since 43 min by now it does not work for windows.
Can a windows contributor confirm that?

@Be-ing
Copy link
Contributor Author

Be-ing commented Jul 11, 2021

The long build time was because there was no cache for the branch yet.

@Be-ing
Copy link
Contributor Author

Be-ing commented Jul 11, 2021

I just asked upstream for a new release so we can install from Chocolatey instead of taking 10 minutes to build sccache from source.

@Be-ing
Copy link
Contributor Author

Be-ing commented Jul 11, 2021

I am confused why GitHub Actions keeps having cache misses.

Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge and keep an eye on Windows build times to detect possible regressions?

The new version is recommended and cleaner.

@daschuer
Copy link
Member

Yes, I have just compared with other PRs and it is always around 50 min. This is suspicious, but no regression.

@daschuer daschuer merged commit 82f8c78 into mixxxdj:main Jul 13, 2021
@Be-ing Be-ing deleted the sccache_hack_remove branch October 17, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants