Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache timing appears to be broken #1817

Closed
luser opened this issue Jun 20, 2023 · 0 comments · Fixed by #1818
Closed

Cache timing appears to be broken #1817

luser opened this issue Jun 20, 2023 · 0 comments · Fixed by #1818

Comments

@luser
Copy link
Contributor

luser commented Jun 20, 2023

I noticed this while looking at the log in #1756. All of the cache hit log lines read Cache hit in 0.000 s. It looks like this got broken at some point. The duration is calculated here:

let duration = start.elapsed();

but that's prior to where it actually awaits the cache get future:

let lookup = match cache_status.await {

This also means the summary stats don't work either:

Average cache read hit            0.000 s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant