Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timing of cache reads. Fixes #1817 #1818

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

luser
Copy link
Contributor

@luser luser commented Jun 21, 2023

I'm not sure when this got broken, but the cache read timing isn't being calculated properly. This change fixes it. I added a test by extending the MockStorage struct (which is only used in one other test) to include an optional delay on get, and just asserting that the cache read duration is >= that delay. Fixes #1817

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2023

Codecov Report

Patch coverage: 30.00% and project coverage change: +0.01 🎉

Comparison is base (62c8f0a) 29.48% compared to head (0613eb1) 29.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1818      +/-   ##
==========================================
+ Coverage   29.48%   29.49%   +0.01%     
==========================================
  Files          49       49              
  Lines       17780    17843      +63     
  Branches     8592     8637      +45     
==========================================
+ Hits         5242     5263      +21     
- Misses       7353     7358       +5     
- Partials     5185     5222      +37     
Impacted Files Coverage Δ
src/test/mock_storage.rs 25.80% <28.57%> (-1.12%) ⬇️
src/compiler/compiler.rs 35.63% <30.15%> (-0.12%) ⬇️

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sylvestre
Copy link
Collaborator

welcome back @luser ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache timing appears to be broken
3 participants