Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to keep linemarkers #1096

Closed
wants to merge 1 commit into from

Conversation

milahu
Copy link
Contributor

@milahu milahu commented Jan 14, 2022

workaround for #1026

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2022

Codecov Report

Merging #1096 (d9803e4) into master (58fffa6) will increase coverage by 0.14%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1096      +/-   ##
==========================================
+ Coverage   56.81%   56.96%   +0.14%     
==========================================
  Files          47       47              
  Lines       11797    11833      +36     
  Branches     2142     2149       +7     
==========================================
+ Hits         6703     6741      +38     
+ Misses       3772     3769       -3     
- Partials     1322     1323       +1     
Impacted Files Coverage Δ
src/compiler/gcc.rs 78.48% <16.66%> (-0.39%) ⬇️
src/util.rs 58.40% <0.00%> (-0.45%) ⬇️
src/compiler/rust.rs 57.54% <0.00%> (-0.15%) ⬇️
src/compiler/compiler.rs 72.06% <0.00%> (-0.08%) ⬇️
src/server.rs 59.71% <0.00%> (+0.11%) ⬆️
src/compiler/args.rs 76.64% <0.00%> (+0.23%) ⬆️
src/compiler/c.rs 64.50% <0.00%> (+4.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58fffa6...d9803e4. Read the comment docs.

@sylvestre
Copy link
Collaborator

could you please add a test ? thanks

@sylvestre
Copy link
Collaborator

ping?

@milahu

This comment was marked as spam.

@sylvestre
Copy link
Collaborator

ok

@sylvestre sylvestre closed this Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants