Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable gha actions storage for the default feature set #1453

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

drahnr
Copy link
Collaborator

@drahnr drahnr commented Dec 7, 2022

Enabling by default is mandated by popularity and being able to integrate into gha workflows

@sylvestre
Copy link
Collaborator

Thanks. I will make a second release with this

@sylvestre
Copy link
Collaborator

Same issue as in the release:

E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/main/b/binutils/binutils-aarch64-linux-gnu_2.34-6ubuntu1.3_amd64.deb  404  Not Found [IP: 40.81.13.82 80]
E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/main/b/binutils/binutils-multiarch_2.34-6ubuntu1.3_amd64.deb  404  Not Found [IP: 40.81.13.82 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2022

Codecov Report

Base: 23.72% // Head: 23.54% // Decreases project coverage by -0.18% ⚠️

Coverage data is based on head (a2ff02b) compared to base (b7caab4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1453      +/-   ##
==========================================
- Coverage   23.72%   23.54%   -0.19%     
==========================================
  Files          48       49       +1     
  Lines       22336    22414      +78     
  Branches    10222    10263      +41     
==========================================
- Hits         5300     5277      -23     
- Misses      11402    11532     +130     
+ Partials     5634     5605      -29     
Impacted Files Coverage Δ
src/jobserver.rs 47.91% <0.00%> (-4.17%) ⬇️
src/cache/disk.rs 35.61% <0.00%> (-2.74%) ⬇️
src/cache/cache.rs 37.23% <0.00%> (-1.56%) ⬇️
src/compiler/args.rs 60.84% <0.00%> (-1.24%) ⬇️
src/azure/blobstore.rs 22.10% <0.00%> (-1.06%) ⬇️
src/mock_command.rs 51.68% <0.00%> (-0.75%) ⬇️
src/cache/azure.rs 30.88% <0.00%> (-0.74%) ⬇️
src/compiler/c.rs 38.76% <0.00%> (-0.46%) ⬇️
src/util.rs 35.93% <0.00%> (-0.32%) ⬇️
src/compiler/compiler.rs 35.99% <0.00%> (-0.22%) ⬇️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sylvestre sylvestre merged commit a1dae72 into main Dec 7, 2022
@Xuanwo Xuanwo deleted the bernhard-gha-enable-by-default branch March 5, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants