-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Migrate azblob to opendal based #1463
Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Codecov ReportBase: 30.11% // Head: 29.79% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1463 +/- ##
==========================================
- Coverage 30.11% 29.79% -0.32%
==========================================
Files 49 47 -2
Lines 17408 16974 -434
Branches 8295 8056 -239
==========================================
- Hits 5242 5057 -185
+ Misses 6553 6501 -52
+ Partials 5613 5416 -197
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>
Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>
I like the kind of PRs that delete more code than it adds, thank you! I don't think we should have tests for the inner details of opendal, after all we are becoming a consumer of that and it's not a direct development concern of sccache. |
This PR includes the following changes:
Storage
upon opendal::Operator so that all opendal services can be used as cache storageMuch azure tests have been removed, but opendal have all of them covered in OpenDAL's behavior test at Service Test Azblob.