Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migrate azblob to opendal based #1463

Merged
merged 7 commits into from
Dec 12, 2022

Conversation

Xuanwo
Copy link
Collaborator

@Xuanwo Xuanwo commented Dec 11, 2022

This PR includes the following changes:

  • Implement Storage upon opendal::Operator so that all opendal services can be used as cache storage
  • Migrate azure implement to opendal based.

Much azure tests have been removed, but opendal have all of them covered in OpenDAL's behavior test at Service Test Azblob.

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2022

Codecov Report

Base: 30.11% // Head: 29.79% // Decreases project coverage by -0.31% ⚠️

Coverage data is based on head (a4dc9d0) compared to base (4401cd9).
Patch coverage: 12.32% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1463      +/-   ##
==========================================
- Coverage   30.11%   29.79%   -0.32%     
==========================================
  Files          49       47       -2     
  Lines       17408    16974     -434     
  Branches     8295     8056     -239     
==========================================
- Hits         5242     5057     -185     
+ Misses       6553     6501      -52     
+ Partials     5613     5416     -197     
Impacted Files Coverage Δ
src/cache/azure.rs 0.00% <0.00%> (-31.62%) ⬇️
src/cache/s3.rs 44.44% <0.00%> (+14.55%) ⬆️
src/lib.rs 8.87% <ø> (-0.41%) ⬇️
src/cache/cache.rs 34.54% <12.76%> (-3.12%) ⬇️
src/config.rs 36.56% <15.78%> (-0.84%) ⬇️
src/compiler/gcc.rs 54.60% <0.00%> (-0.98%) ⬇️
src/mock_command.rs 51.31% <0.00%> (-0.75%) ⬇️
src/compiler/c.rs 38.53% <0.00%> (-0.69%) ⬇️
src/util.rs 34.68% <0.00%> (-0.63%) ⬇️
src/compiler/args.rs 61.19% <0.00%> (-0.53%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/cache/cache.rs Outdated Show resolved Hide resolved
src/config.rs Outdated Show resolved Hide resolved
src/config.rs Outdated Show resolved Hide resolved
Xuanwo and others added 3 commits December 12, 2022 01:31
Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>
Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>
@drahnr
Copy link
Collaborator

drahnr commented Dec 12, 2022

I like the kind of PRs that delete more code than it adds, thank you! I don't think we should have tests for the inner details of opendal, after all we are becoming a consumer of that and it's not a direct development concern of sccache.

@sylvestre sylvestre merged commit 8e0d07d into mozilla:main Dec 12, 2022
@Xuanwo Xuanwo deleted the migrate-azblob-to-opendal branch December 12, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants