Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable logging for opendal operations #1497

Merged
merged 1 commit into from Dec 23, 2022

Conversation

Xuanwo
Copy link
Collaborator

@Xuanwo Xuanwo commented Dec 20, 2022

Signed-off-by: Xuanwo github@xuanwo.io

This PR introduces two changes:

  • Enable logging for opendal operations for better debugging
  • Omit error print while meeting object not found (cache miss)

Signed-off-by: Xuanwo <github@xuanwo.io>
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Base: 29.95% // Head: 29.93% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (2c65603) compared to base (c0c9bc0).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1497      +/-   ##
==========================================
- Coverage   29.95%   29.93%   -0.02%     
==========================================
  Files          47       47              
  Lines       16683    16687       +4     
  Branches     7903     7906       +3     
==========================================
- Hits         4998     4996       -2     
- Misses       6368     6374       +6     
  Partials     5317     5317              
Impacted Files Coverage Δ
src/cache/azure.rs 0.00% <0.00%> (ø)
src/cache/cache.rs 35.65% <0.00%> (-0.14%) ⬇️
src/cache/gcs.rs 12.76% <0.00%> (+1.89%) ⬆️
src/cache/s3.rs 43.47% <0.00%> (-0.97%) ⬇️
src/test/utils.rs 36.36% <0.00%> (-4.05%) ⬇️
src/mock_command.rs 51.31% <0.00%> (-0.38%) ⬇️
src/server.rs 32.10% <0.00%> (-0.22%) ⬇️
src/lib.rs 8.76% <0.00%> (-0.06%) ⬇️
src/util.rs 34.09% <0.00%> (ø)
src/compiler/c.rs 38.72% <0.00%> (+0.22%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sylvestre sylvestre merged commit 7779f71 into mozilla:main Dec 23, 2022
@Xuanwo Xuanwo deleted the polish-logs-for-opendal branch December 23, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants