Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept /fsanitize=address as a passthrough option for MSVC #1518

Merged
merged 1 commit into from Dec 31, 2022

Conversation

randombit
Copy link
Contributor

At the moment, invocations using /fsanitize=address are rejected as uncachable by sccache due to it assuming there are multiple input files.

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2022

Codecov Report

Base: 30.00% // Head: 30.03% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (0f12915) compared to base (0d62517).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1518      +/-   ##
==========================================
+ Coverage   30.00%   30.03%   +0.03%     
==========================================
  Files          47       47              
  Lines       16643    16643              
  Branches     7907     7907              
==========================================
+ Hits         4994     4999       +5     
  Misses       6313     6313              
+ Partials     5336     5331       -5     
Impacted Files Coverage Δ
src/compiler/msvc.rs 43.29% <ø> (ø)
src/mock_command.rs 50.93% <0.00%> (-1.50%) ⬇️
src/cache/disk.rs 35.61% <0.00%> (-1.37%) ⬇️
src/lib.rs 9.26% <0.00%> (ø)
src/util.rs 34.09% <0.00%> (ø)
src/compiler/c.rs 38.49% <0.00%> (ø)
src/compiler/rust.rs 33.46% <0.00%> (+0.13%) ⬆️
src/compiler/args.rs 61.55% <0.00%> (+0.17%) ⬆️
src/server.rs 31.72% <0.00%> (+0.21%) ⬆️
src/compiler/gcc.rs 54.54% <0.00%> (+0.41%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@randombit
Copy link
Contributor Author

FreeBSD CI build is failing but afaict it is not related to this change

@sylvestre sylvestre merged commit dd418ab into mozilla:main Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants