Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow sccache keep running after hitting rate limit during check #1557

Merged
merged 3 commits into from Jan 12, 2023

Conversation

Xuanwo
Copy link
Collaborator

@Xuanwo Xuanwo commented Jan 12, 2023

Signed-off-by: Xuanwo github@xuanwo.io

This PR will allow sccache to keep running after hitting the rate limit error.

We introduce this change because we could have services that have very strict limit on our requests. During storage check, it's better to tolerate them and keep running because there are few things either we or our users can do on this.

Signed-off-by: Xuanwo <github@xuanwo.io>
docs/GHA.md Outdated Show resolved Hide resolved
Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2023

Codecov Report

Base: 30.89% // Head: 30.79% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (38167e8) compared to base (f452e4b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1557      +/-   ##
==========================================
- Coverage   30.89%   30.79%   -0.10%     
==========================================
  Files          48       48              
  Lines       16598    16601       +3     
  Branches     7906     7907       +1     
==========================================
- Hits         5128     5113      -15     
  Misses       6106     6106              
- Partials     5364     5382      +18     
Impacted Files Coverage Δ
src/cache/cache.rs 39.84% <0.00%> (-0.47%) ⬇️
src/jobserver.rs 50.00% <0.00%> (-4.17%) ⬇️
src/cache/disk.rs 35.61% <0.00%> (-1.37%) ⬇️
src/test/utils.rs 37.37% <0.00%> (-1.02%) ⬇️
src/mock_command.rs 52.05% <0.00%> (-0.75%) ⬇️
src/compiler/gcc.rs 54.69% <0.00%> (-0.73%) ⬇️
src/compiler/args.rs 61.70% <0.00%> (-0.71%) ⬇️
src/lru_disk_cache/mod.rs 41.03% <0.00%> (-0.31%) ⬇️
src/compiler/c.rs 38.44% <0.00%> (-0.23%) ⬇️
src/compiler/compiler.rs 36.09% <0.00%> (-0.15%) ⬇️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sylvestre sylvestre merged commit 66f44cb into mozilla:main Jan 12, 2023
@Xuanwo Xuanwo deleted the allow-rate-limit-error branch February 22, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants