New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support nvcc's --threads
flag
#1571
Conversation
Codecov ReportBase: 30.85% // Head: 31.00% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1571 +/- ##
==========================================
+ Coverage 30.85% 31.00% +0.15%
==========================================
Files 48 48
Lines 16557 16625 +68
Branches 7934 7976 +42
==========================================
+ Hits 5109 5155 +46
- Misses 6062 6063 +1
- Partials 5386 5407 +21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
could you please run rustfmt on your change? thanks |
@sylvestre done, thanks. About this PR, the This would prevent existing caches from being invalidated, but more importantly, it would allow devs (and CI machines) with different values for |
…s that shouldn't affect the hash key
I added a new |
@@ -100,6 +100,8 @@ pub struct ParsedArguments { | |||
pub common_args: Vec<OsString>, | |||
/// Commandline arguments for the compiler that specify the architecture given | |||
pub arch_args: Vec<OsString>, | |||
/// Commandline arguments for the preprocessor or the compiler that don't affect the computed hash. | |||
pub unhashed_args: Vec<OsString>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to have another statement, that none of these arguments listed may in any circumstance change the resulting artifact.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good structural change.
Thank you!
* support the nvcc --threads flag * fix lint * add unhashed_args vec to ParsedArguments struct for compiler arguments that shouldn't affect the hash key * add test to check unhashed args make it into the compile command
This PR adds support for nvcc's
--threads
flag.