Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MSVC flag 'external:anglebrackets' #1572

Merged
merged 1 commit into from Jan 28, 2023

Conversation

Tiwalun
Copy link
Contributor

@Tiwalun Tiwalun commented Jan 20, 2023

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2023

Codecov Report

Base: 31.04% // Head: 31.01% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (5858ff6) compared to base (c38b6ba).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1572      +/-   ##
==========================================
- Coverage   31.04%   31.01%   -0.04%     
==========================================
  Files          48       48              
  Lines       16568    16568              
  Branches     7927     7931       +4     
==========================================
- Hits         5144     5138       -6     
+ Misses       6070     6068       -2     
- Partials     5354     5362       +8     
Impacted Files Coverage Δ
src/compiler/msvc.rs 43.35% <ø> (ø)
src/jobserver.rs 47.91% <0.00%> (-2.09%) ⬇️
src/compiler/c.rs 38.21% <0.00%> (-1.15%) ⬇️
src/test/utils.rs 37.37% <0.00%> (-1.02%) ⬇️
src/test/tests.rs 32.87% <0.00%> (-0.69%) ⬇️
src/util.rs 34.52% <0.00%> (-0.66%) ⬇️
src/server.rs 32.15% <0.00%> (-0.42%) ⬇️
src/cache/cache.rs 39.46% <0.00%> (-0.39%) ⬇️
src/lru_disk_cache/mod.rs 41.33% <0.00%> (-0.31%) ⬇️
src/compiler/gcc.rs 55.72% <0.00%> (-0.11%) ⬇️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sylvestre sylvestre merged commit 65e29e7 into mozilla:main Jan 28, 2023
@sylvestre
Copy link
Collaborator

thanks!

@Tiwalun Tiwalun deleted the add-msvc-external-anglebrackets branch January 28, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants