Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Webdav (a.k.a HTTP Cache) support #1597

Merged
merged 10 commits into from Feb 14, 2023

Conversation

Xuanwo
Copy link
Collaborator

@Xuanwo Xuanwo commented Feb 12, 2023

Signed-off-by: Xuanwo github@xuanwo.io

Fix #1171

Signed-off-by: Xuanwo <github@xuanwo.io>
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2023

Codecov Report

Base: 30.85% // Head: 30.87% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (5edfb33) compared to base (6a66de5).
Patch coverage: 19.04% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1597      +/-   ##
==========================================
+ Coverage   30.85%   30.87%   +0.01%     
==========================================
  Files          48       49       +1     
  Lines       16601    16637      +36     
  Branches     8019     8039      +20     
==========================================
+ Hits         5123     5136      +13     
- Misses       6210     6228      +18     
- Partials     5268     5273       +5     
Impacted Files Coverage Δ
src/cache/cache.rs 38.95% <0.00%> (-1.28%) ⬇️
src/cache/webdav.rs 0.00% <0.00%> (ø)
src/config.rs 35.33% <25.92%> (-0.26%) ⬇️
tests/harness/mod.rs 44.18% <100.00%> (+0.65%) ⬆️
src/test/utils.rs 37.37% <0.00%> (-2.03%) ⬇️
src/cache/disk.rs 34.24% <0.00%> (-1.37%) ⬇️
src/server.rs 30.84% <0.00%> (-0.73%) ⬇️
src/util.rs 37.50% <0.00%> (ø)
src/mock_command.rs 53.03% <0.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sylvestre
Copy link
Collaborator

sylvestre commented Feb 12, 2023 via email

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@sylvestre
Copy link
Collaborator

Could you please also reference it in the readme?
https://github.com/mozilla/sccache/blob/main/README.md

@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Feb 13, 2023

DONE!

docs/Webdav.md Outdated Show resolved Hide resolved
docs/Webdav.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Xuanwo and others added 4 commits February 13, 2023 15:18
Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>
Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>
Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>
Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>
src/config.rs Outdated Show resolved Hide resolved
@dtretyakov
Copy link
Contributor

@Xuanwo thanks for your work. Is it possible to provide credentials for WebDAV service?

@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Feb 13, 2023

@Xuanwo thanks for your work. Is it possible to provide credentials for WebDAV service?

Yes! The feature has been added in new release of opendal: apache/opendal#1337.

I will add it in next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

questioning about : HTTP storage backend
4 participants