Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Cleanup superfluous dependency #1602

Merged
merged 1 commit into from
Feb 12, 2023
Merged

Conversation

Xuanwo
Copy link
Collaborator

@Xuanwo Xuanwo commented Feb 12, 2023

Signed-off-by: Xuanwo <github@xuanwo.io>
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2023

Codecov Report

Base: 30.85% // Head: 30.84% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (e43a57e) compared to base (b8ba6b6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1602      +/-   ##
==========================================
- Coverage   30.85%   30.84%   -0.02%     
==========================================
  Files          48       48              
  Lines       16602    16601       -1     
  Branches     8008     8019      +11     
==========================================
- Hits         5122     5120       -2     
+ Misses       6220     6210      -10     
- Partials     5260     5271      +11     
Impacted Files Coverage Δ
src/test/utils.rs 36.36% <0.00%> (-1.02%) ⬇️
src/mock_command.rs 51.89% <0.00%> (-0.76%) ⬇️
src/compiler/args.rs 61.79% <0.00%> (-0.71%) ⬇️
src/compiler/gcc.rs 54.75% <0.00%> (-0.52%) ⬇️
src/cache/cache.rs 39.46% <0.00%> (-0.39%) ⬇️
src/compiler/compiler.rs 35.82% <0.00%> (-0.29%) ⬇️
src/server.rs 31.56% <0.00%> (-0.11%) ⬇️
src/lru_disk_cache/mod.rs 41.46% <0.00%> (ø)
src/compiler/rust.rs 33.46% <0.00%> (+0.06%) ⬆️
src/compiler/c.rs 38.39% <0.00%> (+0.22%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sylvestre sylvestre merged commit 6a66de5 into mozilla:main Feb 12, 2023
@sylvestre
Copy link
Collaborator

thanks

@Xuanwo Xuanwo deleted the dep-cleanup branch February 12, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

superfluous dependency on chrono superfluous dependency on time superfluous dev-dependency on wiremock
4 participants