Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV to 1.64 #1649

Merged
merged 2 commits into from Mar 21, 2023
Merged

Bump MSRV to 1.64 #1649

merged 2 commits into from Mar 21, 2023

Conversation

Xuanwo
Copy link
Collaborator

@Xuanwo Xuanwo commented Mar 9, 2023

Read more detail at #1609

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (bc0718f) 29.58% compared to head (e7fffe1) 29.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1649      +/-   ##
==========================================
- Coverage   29.58%   29.51%   -0.08%     
==========================================
  Files          49       49              
  Lines       17030    17030              
  Branches     8209     8198      -11     
==========================================
- Hits         5039     5027      -12     
+ Misses       6997     6994       -3     
- Partials     4994     5009      +15     

see 13 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Mar 10, 2023

freebsd tests seems always failed since e534072

@sylvestre
Copy link
Collaborator

freebsd tests seems always failed since e534072

Let's see:
#1651

@sylvestre
Copy link
Collaborator

sorry, it needs to be rebased

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Mar 13, 2023

sorry, it needs to be rebased

DONE

@Xuanwo Xuanwo requested review from sylvestre and drahnr March 17, 2023 12:27
@sylvestre
Copy link
Collaborator

I am wondering if we should not wait after we released 0.4.0 before merging this

@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Mar 20, 2023

I am wondering if we should not wait after we released 0.4.0 before merging this

It's more common to bump MSRV when bumping minor releases. But both LGTM.

@sylvestre sylvestre merged commit 2557e92 into mozilla:main Mar 21, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants