snap: refresh snap for `base: core22` #1679

Saviq · 2023-03-22T12:21:14Z

This refreshes the snap packaging so that https://snapcraft.io/sccache can be served better.

Saviq · 2023-03-22T12:22:56Z

This is now building here:

https://launchpad.net/~saviq/+snap/edge - it failed on s390x and ppc64el due to dependency issues.

I will follow up with a rework of the configuration hook to work with a configuration file rather than the environment.

sylvestre · 2023-03-22T12:23:55Z

oh, thanks for doing this. We noticed that it didn't get update for a while.

Could you please make sure it doesn't run as root in snap? thanks

Could you please add me as maintainer too ? (sylvestre@debian.org is my login - I am doing that as Mozilla upstream)

snap/snapcraft.yaml

sylvestre · 2023-03-22T12:26:05Z

About the s390x port, see #1442

snap/snapcraft.yaml

Saviq · 2023-03-22T12:36:45Z

oh, thanks for doing this. We noticed that it didn't get update for a while.

Yeah, I never dotted all the "i"'s on this…

Could you please make sure it doesn't run as root in snap? thanks

Could you please add me as maintainer too ? (sylvestre@debian.org is my login - I am doing that as Mozilla upstream)

You've got mail, and we've requested it to get moved to Mozilla:

https://forum.snapcraft.io/t/publisher-change-request-for-sccache/34440

About the s390x port, see #1442

ACK.

I've added workflows to build the snap, but you'd have to enable actions from canonical/actions/* ideally. Or we can drop them, or avoid using actions that aren't allowed with some copy-paste:

https://github.com/mozilla/sccache/actions/runs/4489852240

sylvestre · 2023-03-22T12:38:07Z

yeah, I will ask the team to enable it, thanks :)

Saviq · 2023-03-22T12:40:35Z

yeah, I will ask the team to enable it, thanks :)

Cool, for those to upload to the snap store, you'll need to set the SNAPCRAFT_TOKEN secret to the output of:

snapcraft export-login --snaps sccache --channels="*edge*" --acls package_access,package_push,package_release -

Or drop that part and store as artifacts instead, your call :)

Personally I use a bot account for those uploads, so if you have one like that - and want CI to upload to the store - let's add it as a collaborator as well?

sylvestre · 2023-03-22T13:25:31Z

Uploading them on tagged releases works for me

Saviq · 2023-03-22T13:57:43Z

Could you please make sure it doesn't run as root in snap? thanks

I've just dropped the daemon altogether. From what I understand about how sccache operates, it doesn't make sense to have a central server.

Saviq · 2023-03-22T14:03:02Z

Uploading them on tagged releases works for me

I'd say it only makes sense to upload from PRs (that's how it's currently set up), to edge/pr<number> channels, for easy testing of the changes.

Builds into other channels should be set up at https://snapcraft.io/sccache/builds, or through Launchpad snap recipes, once we merge this PR (no point before we do) - this will get you more architectures and a more stable build environment than the Actions one.

If you have other means of testing, we may well skip publishing the snap from PRs. I'd still build from PRs in case something breaks in there.

codecov-commenter · 2023-03-22T14:23:08Z

Codecov Report

Patch coverage has no change and project coverage change: +0.07 🎉

Comparison is base (0af46b1) 29.33% compared to head (ac1d5ac) 29.40%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1679      +/-   ##
==========================================
+ Coverage   29.33%   29.40%   +0.07%     
==========================================
  Files          49       49              
  Lines       17056    17056              
  Branches     8272     8271       -1     
==========================================
+ Hits         5004     5016      +12     
- Misses       7000     7002       +2     
+ Partials     5052     5038      -14

see 12 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

snap/snapcraft.yaml

.github/workflows/snap.yml

sylvestre · 2023-04-05T14:41:13Z

@Saviq Seems that it needs also another action:

Bad request - diddlesnaps/snapcraft-multiarch-action@v1 is not allowed to be used in mozilla/sccache.

Can we ignore it?

Saviq · 2023-04-05T14:56:25Z

@sylvestre I could move the build-snap to @release to avoid that, but then it could only build for amd64.

Your call!

Saviq · 2023-04-05T15:59:55Z

@sylvestre feel free to push this:

diff --git a/.github/workflows/snap.yml b/.github/workflows/snap.yml
index f002d37..84c532c 100644
--- a/.github/workflows/snap.yml
+++ b/.github/workflows/snap.yml
@@ -10,16 +10,6 @@ jobs:
 
     timeout-minutes: 45
 
-    strategy:
-      matrix:
-        platform:
-        - amd64
-        - armhf
-        - arm64
-        # Broken dependencies: - ppc64el
-        # https://github.com/mozilla/sccache/issues/1442
-        # Broken environment: - s390x
-
     steps:
     - name: Check out code
       uses: actions/checkout@v3
@@ -27,9 +17,8 @@ jobs:
         fetch-depth: 0  # needed for version determination
 
     - name: Build and publish the snap
-      uses: canonical/actions/build-snap@multiarch
+      uses: canonical/actions/build-snap@release
       with:
-        architecture: ${{ matrix.platform }}
         snapcraft-token: ${{ secrets.SNAPCRAFT_TOKEN }}
         publish: ${{ github.event_name == 'pull_request' && github.repository == github.event.pull_request.head.repo.full_name }}
         publish-channel: edge/pr${{ github.event.number }}

sylvestre · 2023-04-11T08:06:53Z

@Saviq "I could move the build-snap to @Release to avoid that, but then it could only build for amd64."
=> yeah, this is fine, thanks

Saviq · 2023-04-11T09:26:41Z

yeah, this is fine, thanks

Done.

There's not really a point running a system-wide daemon of sccache. At least not by default. `sccache` forks a local server if one isn't running already, and does it as the current user. The server needs write access to the compilation path, so a central server… doesn't work very well.

Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>

Other arches require untrusted actions.

sylvestre · 2023-04-12T19:50:30Z

I think we fixed the server side configuration but we have an error:


Creating new base instance 'base-instance-snapcraft-buildd-base-v00--a12c0d0071c13c372948' from instance.
readlink: missing operand
Try 'readlink --help' for more information.
Run REVIEW_OPTS=()
Errors
------
 - lint-snap-v2:confinement_classic
	(NEEDS REVIEW) confinement 'classic' not allowed. If your snap needs classic confinement to function, please make a request for this snap to use classic by creating a new topic in the forum using the 'store-requests' category and detail the technical reasons why classic is required.
	https://forum.snapcraft.io/t/process-for-reviewing-classic-confinement-snaps/1460
sccache_v0.4.1-25-g7cba138_amd64.snap: FAIL

Saviq · 2023-04-13T07:32:51Z

I think we fixed the server side configuration but we have an error:

Fixed, sorry!

sylvestre · 2023-04-17T12:26:10Z

no worries :)

sylvestre · 2023-04-17T13:25:34Z

@Saviq sorry for the dumb question but how do we publish it on snap ?
I see see the old release
https://snapcraft.io/sccache

Saviq · 2023-04-17T13:51:07Z

@Saviq sorry for the dumb question but how do we publish it on snap ? I see see the old release https://snapcraft.io/sccache

Hey, so https://snapcraft.io/docs/releasing-your-app manually, but if you set the SNAPCRAFT_TOKEN secret, we can upload from CI.

Saviq · 2023-04-17T13:53:29Z

@sylvestre to get builds from main, best probably hook it up under https://snapcraft.io/sccache/builds - you'll then just need to move the edge revisions to beta/candidate/stable as appropriate, here: https://snapcraft.io/sccache/releases

sylvestre reviewed Mar 22, 2023

View reviewed changes

snap/snapcraft.yaml Outdated Show resolved Hide resolved

sylvestre reviewed Mar 22, 2023

View reviewed changes

snap/snapcraft.yaml Outdated Show resolved Hide resolved

Saviq commented Mar 22, 2023

View reviewed changes

snap/snapcraft.yaml Outdated Show resolved Hide resolved

Saviq force-pushed the snap branch from cdc550d to aa31ba0 Compare March 22, 2023 13:56

sylvestre reviewed Mar 22, 2023

View reviewed changes

snap/snapcraft.yaml Outdated Show resolved Hide resolved

.github/workflows/snap.yml Outdated Show resolved Hide resolved

Saviq force-pushed the snap branch from dd13b27 to 98b36f1 Compare March 22, 2023 17:26

Xuanwo changed the title ~~snap: refresh snap for base: core22`~~ snap: refresh snap for base: core22 Apr 5, 2023

Saviq force-pushed the snap branch from 653e34d to 9039249 Compare April 5, 2023 18:55

sylvestre force-pushed the snap branch from 4bd7a8e to 3cea4d8 Compare April 11, 2023 09:52

Saviq and others added 6 commits April 12, 2023 18:09

snap: refresh snap for base: core22

9363574

ci: add snap workflows

9a84a67

snap: refer to why some arches are broken

8785310

Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>

snap: fix description

a5a9560

snap: only do amd64

d114486

Other arches require untrusted actions.

sylvestre force-pushed the snap branch from 3cea4d8 to d114486 Compare April 12, 2023 16:09

snap: allow classic in snap review

ac1d5ac

sylvestre merged commit 2a7db60 into mozilla:main Apr 17, 2023
36 of 37 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

snap: refresh snap for `base: core22` #1679

snap: refresh snap for `base: core22` #1679

Saviq commented Mar 22, 2023

Saviq commented Mar 22, 2023

sylvestre commented Mar 22, 2023

sylvestre commented Mar 22, 2023

Saviq commented Mar 22, 2023 •

edited

sylvestre commented Mar 22, 2023

Saviq commented Mar 22, 2023 •

edited

sylvestre commented Mar 22, 2023

Saviq commented Mar 22, 2023

Saviq commented Mar 22, 2023

codecov-commenter commented Mar 22, 2023 •

edited

sylvestre commented Apr 5, 2023

Saviq commented Apr 5, 2023 •

edited

Saviq commented Apr 5, 2023

sylvestre commented Apr 11, 2023

Saviq commented Apr 11, 2023

sylvestre commented Apr 12, 2023

Saviq commented Apr 13, 2023

sylvestre commented Apr 17, 2023

sylvestre commented Apr 17, 2023

Saviq commented Apr 17, 2023

Saviq commented Apr 17, 2023

snap: refresh snap for base: core22 #1679

snap: refresh snap for base: core22 #1679

Conversation

Saviq commented Mar 22, 2023

Saviq commented Mar 22, 2023

sylvestre commented Mar 22, 2023

sylvestre commented Mar 22, 2023

Saviq commented Mar 22, 2023 • edited

sylvestre commented Mar 22, 2023

Saviq commented Mar 22, 2023 • edited

sylvestre commented Mar 22, 2023

Saviq commented Mar 22, 2023

Saviq commented Mar 22, 2023

codecov-commenter commented Mar 22, 2023 • edited

Codecov Report

sylvestre commented Apr 5, 2023

Saviq commented Apr 5, 2023 • edited

Saviq commented Apr 5, 2023

sylvestre commented Apr 11, 2023

Saviq commented Apr 11, 2023

sylvestre commented Apr 12, 2023

Saviq commented Apr 13, 2023

sylvestre commented Apr 17, 2023

sylvestre commented Apr 17, 2023

Saviq commented Apr 17, 2023

Saviq commented Apr 17, 2023

snap: refresh snap for `base: core22` #1679

snap: refresh snap for `base: core22` #1679

Saviq commented Mar 22, 2023 •

edited

Saviq commented Mar 22, 2023 •

edited

codecov-commenter commented Mar 22, 2023 •

edited

Saviq commented Apr 5, 2023 •

edited