Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor import style #1701

Merged
merged 2 commits into from Mar 29, 2023
Merged

Refactor import style #1701

merged 2 commits into from Mar 29, 2023

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Mar 29, 2023

Refactors the styles to import crates.

@sylvestre
Copy link
Collaborator

long overdue, thanks :)

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.09 🎉

Comparison is base (da77709) 29.60% compared to head (5c31fb5) 29.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1701      +/-   ##
==========================================
+ Coverage   29.60%   29.69%   +0.09%     
==========================================
  Files          49       49              
  Lines       17056    17054       -2     
  Branches     8213     8211       -2     
==========================================
+ Hits         5049     5065      +16     
+ Misses       7007     7001       -6     
+ Partials     5000     4988      -12     
Impacted Files Coverage Δ
src/cache/cache.rs 38.43% <ø> (ø)
src/cache/disk.rs 35.61% <ø> (ø)
src/cache/gcs.rs 9.80% <ø> (ø)
src/compiler/c.rs 38.16% <ø> (-0.46%) ⬇️
src/compiler/clang.rs 52.73% <ø> (ø)
src/compiler/compiler.rs 36.25% <ø> (ø)
src/compiler/diab.rs 47.96% <ø> (ø)
src/compiler/gcc.rs 55.56% <ø> (+0.20%) ⬆️
src/compiler/msvc.rs 44.76% <ø> (-0.11%) ⬇️
src/compiler/nvcc.rs 35.32% <ø> (ø)
... and 10 more

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Xuanwo Xuanwo merged commit a2d1009 into mozilla:main Mar 29, 2023
36 checks passed
@tottoto tottoto deleted the refactor-import-style branch March 29, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants