Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe the default conf file locations in docs/Configuration.md #1706

Merged

Conversation

starrify
Copy link
Contributor

@starrify starrify commented Apr 3, 2023

This is a minor doc change.

The list of default paths are taken from docs/DistributedQuickstart.md.

Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.17 ⚠️

Comparison is base (2354d12) 29.63% compared to head (c71b40e) 29.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1706      +/-   ##
==========================================
- Coverage   29.63%   29.46%   -0.17%     
==========================================
  Files          49       49              
  Lines       17054    17056       +2     
  Branches     8214     8274      +60     
==========================================
- Hits         5054     5026      -28     
- Misses       6992     6996       +4     
- Partials     5008     5034      +26     

see 19 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sylvestre
Copy link
Collaborator

fyi, it was documented here:
https://github.com/mozilla/sccache/blob/main/docs/DistributedQuickstart.md
but it is better in this place indeed

@sylvestre sylvestre merged commit a7d32c6 into mozilla:main Apr 6, 2023
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants