Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Response file with carriage returns on windows parse failed #1727

Merged

Conversation

Alexei-Barnes
Copy link
Contributor

@Alexei-Barnes Alexei-Barnes commented Apr 13, 2023

Fixes #1726
Add \r to the allowed whitespace separators between commands for MSVC.

@Xuanwo Xuanwo changed the title Fix #1726 fix: Response file with carriage returns on windows parse failed Apr 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2023

Codecov Report

Patch coverage: 57.14% and project coverage change: +0.14 🎉

Comparison is base (0af46b1) 29.33% compared to head (1c97927) 29.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1727      +/-   ##
==========================================
+ Coverage   29.33%   29.47%   +0.14%     
==========================================
  Files          49       49              
  Lines       17056    17083      +27     
  Branches     8272     8283      +11     
==========================================
+ Hits         5004     5036      +32     
  Misses       7000     7000              
+ Partials     5052     5047       -5     
Impacted Files Coverage Δ
src/compiler/msvc.rs 45.16% <57.14%> (+0.39%) ⬆️

... and 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@drahnr drahnr merged commit 1267e9d into mozilla:main Apr 13, 2023
35 of 36 checks passed
@Alexei-Barnes Alexei-Barnes deleted the bugfix-1736-msvc-response-file-whitespace branch April 13, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sccache Cannot Parse Response File that uses Carriage Returns Only on Windows
4 participants