Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump msrv to 1.65.0 #1743

Merged
merged 2 commits into from Apr 24, 2023
Merged

Bump msrv to 1.65.0 #1743

merged 2 commits into from Apr 24, 2023

Conversation

NobodyXu
Copy link
Contributor

To fix #1742

Signed-off-by: Jiahao XU Jiahao_XU@outlook.com

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.09 🎉

Comparison is base (6fffb2a) 29.14% compared to head (d6eee31) 29.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1743      +/-   ##
==========================================
+ Coverage   29.14%   29.23%   +0.09%     
==========================================
  Files          49       49              
  Lines       17456    17456              
  Branches     8471     8460      -11     
==========================================
+ Hits         5087     5103      +16     
+ Misses       7297     7245      -52     
- Partials     5072     5108      +36     
Impacted Files Coverage Δ
src/dist/pkg.rs 13.88% <0.00%> (ø)

... and 16 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@drahnr drahnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the new clippy lint that strikes, otherwise, if that's between openssl and no openssl, I'd be very much in favor of bumping msrv

@NobodyXu
Copy link
Contributor Author

NobodyXu commented Apr 22, 2023

Could you fix the new clippy lint that strikes, otherwise, if that's between openssl and no openssl, I'd be very much in favor of bumping msrv

Sure!
I will fix that after having my dinner.

Regarding the openssl, I've figured out how to avoid it in sccache and I will soon update PR #1742 thanks to the cachepot PR you provided @drahnr

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Copy link
Contributor Author

NobodyXu commented Apr 22, 2023

ci/freebsd has spuriously failed again, so it should be ok to merge this PR.

Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit 2c84fb6 into mozilla:main Apr 24, 2023
36 of 37 checks passed
@NobodyXu NobodyXu deleted the bump-msrv branch April 24, 2023 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants