Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added env var to disable multi arch caching #1775

Conversation

coretechsec
Copy link
Contributor

@coretechsec coretechsec commented May 26, 2023

Added an environment variable SCCACHE_CACHE_MULTIARCH to enable caching of multiarch compilations.

This should help in cases such as that raised in #847 (comment)

Added an environment variable SCCACHE_NOCACHE_MULTIARCH to allow disabling caching of multiarch compilations.
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2023

Codecov Report

Patch coverage: 62.50% and project coverage change: -0.06 ⚠️

Comparison is base (b2faf16) 29.42% compared to head (495c057) 29.36%.

❗ Current head 495c057 differs from pull request most recent head d38b796. Consider uploading reports for the commit d38b796 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1775      +/-   ##
==========================================
- Coverage   29.42%   29.36%   -0.06%     
==========================================
  Files          49       49              
  Lines       17626    17638      +12     
  Branches     8511     8517       +6     
==========================================
- Hits         5187     5180       -7     
  Misses       7339     7339              
- Partials     5100     5119      +19     
Impacted Files Coverage Δ
src/compiler/gcc.rs 54.72% <62.50%> (-1.31%) ⬇️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

harryt@coretechsec added 2 commits May 26, 2023 11:32
Flipped logic so that multi arch caching is opt in rather than opt out
Fixes from rustmt and clippy
@coretechsec coretechsec requested a review from Xuanwo May 26, 2023 11:38
Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sylvestre sylvestre merged commit 0ae6bf5 into mozilla:main May 30, 2023
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants