Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't call EC2 Metadata and allow anonymouse if no cred #1800

Merged
merged 4 commits into from
Jun 12, 2023

Conversation

Xuanwo
Copy link
Collaborator

@Xuanwo Xuanwo commented Jun 7, 2023

Fix #1799

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested review from drahnr and sylvestre June 8, 2023 00:50
@sylvestre
Copy link
Collaborator

Could you please add some comments to explain the why ? :)

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Jun 8, 2023

Could you please add some comments to explain the why ? :)

DONE.

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04 🎉

Comparison is base (af6e381) 29.39% compared to head (1f6590d) 29.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1800      +/-   ##
==========================================
+ Coverage   29.39%   29.43%   +0.04%     
==========================================
  Files          49       49              
  Lines       17713    17715       +2     
  Branches     8547     8539       -8     
==========================================
+ Hits         5206     5215       +9     
+ Misses       7348     7346       -2     
+ Partials     5159     5154       -5     
Impacted Files Coverage Δ
src/cache/s3.rs 53.44% <0.00%> (-1.91%) ⬇️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Jun 12, 2023

cc @sylvestre, Please take another look, and release a new version for this fix. Thanks!

@sylvestre sylvestre merged commit ef7daa4 into mozilla:main Jun 12, 2023
39 checks passed
@Xuanwo Xuanwo deleted the fix-no-cred branch June 12, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] SCCACHE_S3_NO_CREDENTIALS=true stopped working in 0.5.0
3 participants