Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3): add server side encryption #1908

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

nebnes
Copy link
Contributor

@nebnes nebnes commented Oct 19, 2023

Add server side encryption with s3

via env
SCCACHE_S3_SERVER_SIDE_ENCRYPTION=true

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (841fb0b) 29.76% compared to head (69a1dbe) 29.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1908      +/-   ##
==========================================
- Coverage   29.76%   29.69%   -0.07%     
==========================================
  Files          50       50              
  Lines       18014    18018       +4     
  Branches     8697     8705       +8     
==========================================
- Hits         5362     5351      -11     
+ Misses       7490     7488       -2     
- Partials     5162     5179      +17     
Files Coverage Δ
src/cache/cache.rs 38.74% <0.00%> (+0.22%) ⬆️
src/cache/s3.rs 52.54% <0.00%> (-1.85%) ⬇️
src/config.rs 29.61% <18.18%> (+0.08%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre
Copy link
Collaborator

please run rustfmt :)

@nebnes nebnes force-pushed the feat/s3-server-side-encryption branch from 9184993 to 6c1cf5d Compare October 19, 2023 10:30
docs/Configuration.md Outdated Show resolved Hide resolved
@sylvestre sylvestre requested a review from Xuanwo October 24, 2023 07:56
@sylvestre
Copy link
Collaborator

@Xuanwo what do you think about this ? :)
it looks good to me

@sylvestre sylvestre force-pushed the feat/s3-server-side-encryption branch from 424ca30 to 69a1dbe Compare October 24, 2023 11:15
@sylvestre sylvestre merged commit cabf26c into mozilla:main Oct 24, 2023
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants