Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When fails to connect, show the error #1952

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

sylvestre
Copy link
Collaborator

Will help with issue #1938

Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (16b2034) 29.80% compared to head (e773c0f) 29.69%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1952      +/-   ##
==========================================
- Coverage   29.80%   29.69%   -0.11%     
==========================================
  Files          51       51              
  Lines       18904    19155     +251     
  Branches     9076     9242     +166     
==========================================
+ Hits         5635     5689      +54     
- Misses       7890     7975      +85     
- Partials     5379     5491     +112     
Files Coverage Δ
src/client.rs 4.41% <0.00%> (+0.38%) ⬆️

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre sylvestre merged commit 9513878 into mozilla:main Nov 7, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants