Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off-by-one in line number replacement code #1962

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

glandium
Copy link
Collaborator

Going through the current code fails with:

thread 'tokio-runtime-worker' panicked at src/compiler/c.rs:687:37:
source slice length (3) does not match destination slice length (2)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Going through the current code fails with:
```
thread 'tokio-runtime-worker' panicked at src/compiler/c.rs:687:37:
source slice length (3) does not match destination slice length (2)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
```
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1d71d5d) 29.97% compared to head (05eb9cf) 29.95%.

Files Patch % Lines
src/compiler/c.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1962      +/-   ##
==========================================
- Coverage   29.97%   29.95%   -0.03%     
==========================================
  Files          51       51              
  Lines       19152    19152              
  Branches     9224     9222       -2     
==========================================
- Hits         5741     5737       -4     
+ Misses       7958     7957       -1     
- Partials     5453     5458       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre sylvestre merged commit 78ce03c into mozilla:main Nov 14, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants