Only activate direct mode by default for local #1973
Conversation
|
Rustfmt is not happy |
|
For the record, I can confirm that this solves the issue of direct mode affecting non-local builds. This, however doesn't fix the "getting stuck on Windows" part. I'm not sure, though, why SCCACHE_DIRECT=false wasn't fixing the issue... initialization order? |
Alphare
force-pushed
the
direct-mode.bad-default
branch
from
e56b338
to
c3d3b44
Compare
It will probably be a bit more involved of a bug hunt. I have not yet started to look at it, my end of November is going to be very full.
Do you mean it wasn't disabling it for local config? Or for all configs? Because if the former, we may have another bug, but if the latter, this commit also fixed this behavior. Basically the config was set to |
For non-local configs. I hadn't tried for local configs. But the builds that were hitting the "gets stuck" problem on Windows despite the non-local use weren't fixed by setting SCCACHE_DIRECT=false. As for the "gets stuck" problem itself, I am able to reproduce it... but not locally, only on Firefox CI, which is not going to be super helpful to debug. I'll try a few things, though. |
|
Note the tests are failing with this patch. |
Alphare
force-pushed
the
direct-mode.bad-default
branch
2 times, most recently
from
6210ea2
to
53539b5
Compare
4538675 reverted my initial change. This re-enables direct mode by default, making sure only the disk cache is affected. There may still be an issue with Windows, but details are sparse and no reproduction has been found yet.
|
After fixing the previous failure, it looks like https://github.com/mozilla/sccache/actions/runs/6954981313/job/18922864423?pr=1973 fails, but I'm not convinced it's got anything to do with my patch. |
It's an existing race condition: filed #1982. |
4538675 reverted my initial change.
This re-enables direct mode by default, making sure only the disk cache is affected. There may still be an issue with Windows, but details are sparse and no reproduction has been found yet.
@sylvestre