Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i686 and armv7 musl build via container #2008

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Add i686 and armv7 musl build via container #2008

merged 3 commits into from
Jan 5, 2024

Conversation

jdygert-spok
Copy link
Contributor

@jdygert-spok jdygert-spok commented Jan 5, 2024

This PR adds an i686 and armv7 musl build to CI by using a container, ala #216 (comment).

The ci config is a little jank, but I think it is the best way to do without having to duplicate the steps or move things around too much.

Closes #216.

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (855ec0f) 30.78% compared to head (7083d0c) 30.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2008      +/-   ##
==========================================
- Coverage   30.78%   30.55%   -0.24%     
==========================================
  Files          51       51              
  Lines       19539    19564      +25     
  Branches     9426     9454      +28     
==========================================
- Hits         6015     5977      -38     
+ Misses       7906     7905       -1     
- Partials     5618     5682      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdygert-spok
Copy link
Contributor Author

jdygert-spok commented Jan 5, 2024

I'm silly, #216 asks for i686, I will add that as well.

@jdygert-spok jdygert-spok changed the title Add armv7 musl build via container Add i686 and armv7 musl build via container Jan 5, 2024
@jdygert-spok
Copy link
Contributor Author

Artifacts seem right

sccache-i686: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), statically linked, stripped
sccache-armv7: ELF 32-bit LSB executable, ARM, EABI5 version 1 (SYSV), statically linked, stripped

@sylvestre sylvestre merged commit cf59584 into mozilla:main Jan 5, 2024
41 checks passed
@sylvestre
Copy link
Collaborator

thanks

@jdygert-spok
Copy link
Contributor Author

Could we get a release with these new artifacts?

@sylvestre
Copy link
Collaborator

sure

@jdygert-spok
Copy link
Contributor Author

Thanks!

@sylvestre sylvestre mentioned this pull request Jan 10, 2024
@sylvestre
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add i686 musl builds to releases
3 participants