Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cargo): update dependencies to compatible versions #2009

Merged
merged 21 commits into from
Jan 6, 2024

Conversation

liushuyu
Copy link
Contributor

@liushuyu liushuyu commented Jan 5, 2024

This pull request updates all the dependencies to their latest compatible version (no API changes and no MSRV changes).

This should supersede most of the automated pull requests.

@liushuyu liushuyu force-pushed the update-deps branch 3 times, most recently from 2fef61f to dc7b132 Compare January 5, 2024 23:47
@sylvestre
Copy link
Collaborator

sorry but i would prefer separate commits and not a big one. Way easier to bisect

@liushuyu
Copy link
Contributor Author

liushuyu commented Jan 5, 2024

sorry but i would prefer separate commits and not a big one. Way easier to bisect

One crate per commit?

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4c0d254) 30.74% compared to head (3d447dc) 30.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2009      +/-   ##
==========================================
- Coverage   30.74%   30.42%   -0.33%     
==========================================
  Files          51       51              
  Lines       19564    19638      +74     
  Branches     9452     9437      -15     
==========================================
- Hits         6015     5974      -41     
- Misses       7905     8015     +110     
- Partials     5644     5649       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre
Copy link
Collaborator

sylvestre commented Jan 6, 2024 via email

@liushuyu
Copy link
Contributor Author

liushuyu commented Jan 6, 2024

Yes please Le sam. 6 janv. 2024, 00:48, liushuyu @.***> a écrit :

Done.

@liushuyu liushuyu marked this pull request as ready for review January 6, 2024 01:18
@Xuanwo
Copy link
Collaborator

Xuanwo commented Jan 6, 2024

Perfect!

@Xuanwo Xuanwo merged commit 3d5d41f into mozilla:main Jan 6, 2024
49 checks passed
@liushuyu
Copy link
Contributor Author

liushuyu commented Jan 6, 2024

@Xuanwo

Perfect!

But it looks like you folded all the commits when merging (using that button on the web interface?).
So, would it kind of defeat the purpose of helping with bisecting that @sylvestre mentioned?

@Xuanwo
Copy link
Collaborator

Xuanwo commented Jan 6, 2024

But it looks like you folded all the commits when merging (using that button on the web interface?).
So, would it kind of defeat the purpose of helping with bisecting that @sylvestre mentioned?

Sorry for not reading previous discussion first, do we need to revert this PR first? Cc @sylvestre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants