Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snap: Adapt Snapcraft manifest to Snapcraft 8.0 #2011

Merged
merged 2 commits into from
Jan 6, 2024

Conversation

liushuyu
Copy link
Contributor

@liushuyu liushuyu commented Jan 6, 2024

This pull request adapts the Snapcraft build manifest to the new Snapcraft tool version 8 changes.

This also includes a change to add the sccache-dist program to the Snap package.

Note

If you want the user to use the sccache-dist program (instead of using the auto-renamed sccache.sccache-dist binary) from Snap, an alias request needs to be filed on the Snapcraft forum. Please see https://forum.snapcraft.io/t/process-for-aliases-auto-connections-and-tracks/455 for more information on the process.

@liushuyu
Copy link
Contributor Author

liushuyu commented Jan 6, 2024

I also noticed due to limitations of earlier versions of ring and rustls, sccache won't be able to build or run on CPU architectures other than x86 or ARM.

I will open another PR to attempt to upgrade the dependencies that pull in the older versions of those crates.

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3d5d41f) 30.49% compared to head (170a464) 30.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2011      +/-   ##
==========================================
- Coverage   30.49%   30.28%   -0.21%     
==========================================
  Files          51       51              
  Lines       19638    19638              
  Branches     9437     9437              
==========================================
- Hits         5988     5947      -41     
+ Misses       8015     8014       -1     
- Partials     5635     5677      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liushuyu liushuyu marked this pull request as ready for review January 6, 2024 03:03
@sylvestre sylvestre merged commit c83d350 into mozilla:main Jan 6, 2024
49 checks passed
@sylvestre
Copy link
Collaborator

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants