Add support to specify credentials for S3 explicitly #2210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AJIOB
reviewed
Jul 4, 2024
src/cache/s3.rs
Outdated
| builder.access_key_id(access_key_id); | ||
| } | ||
|
|
||
| if let Some(secret_access_key) = secret_access_key { |
There was a problem hiding this comment.
IMO, we should load password from env only with the login for preventing usage password from another account
There was a problem hiding this comment.
Not sure that I understood what you meant.
You mean we should have checks to bail if only one of these are specified? None of them or both should be specified in order to work?
There was a problem hiding this comment.
Yes, we can do it in this case.
Saruniks
force-pushed
the
explicit-credentials-for-s3-configuration
branch
from
d5f4f48
to
fae1fa3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2210 +/- ##
==========================================
+ Coverage 30.91% 40.86% +9.94%
==========================================
Files 53 55 +2
Lines 20112 20707 +595
Branches 9755 9827 +72
==========================================
+ Hits 6217 8461 +2244
- Misses 7922 8102 +180
+ Partials 5973 4144 -1829 ☔ View full report in Codecov by Sentry. |
sylvestre
force-pushed
the
explicit-credentials-for-s3-configuration
branch
from
987eb66
to
0923a45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2164
No breaking changes, because if environment variables (
SCCACHE_AWS_ACCESS_KEY_ID,SCCACHE_AWS_SECRET_ACCESS_KEY) or file configuration for credentials are not specified, sccache will try to load credentials from environment (includingAWS_ACCESS_KEY_IDandAWS_SECRET_ACCESS_KEY)