Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using icecc-create-env to build environments #321

Closed
wants to merge 4 commits into from

Conversation

mystor
Copy link
Contributor

@mystor mystor commented Oct 19, 2018

I mentioned to @luser that I had whipped up my own create-env system within sccache-dist, due to icecc-create-env not working well for me.

Not sure how well this works, but it can probably at least act as a starting point.

@jrmuizel
Copy link
Contributor

review ping

@jrmuizel
Copy link
Contributor

@mystor also it looks like this doesn't build.

@mystor
Copy link
Contributor Author

mystor commented Nov 13, 2018

Hmm - can't build it locally again due to the build system being unable to find openssl, but here's a fix hopefully(?)

@aidanhs
Copy link
Contributor

aidanhs commented Nov 22, 2018

This looks good to me. I've made a PR to this branch to fix the build failures at mystor#1. It also needs a rebase, but the only conflict is a use line.

Alternatively, I'm happy to do the rebasing and create a new PR. Whatever is easiest.

@aidanhs aidanhs mentioned this pull request Dec 10, 2018
@luser
Copy link
Contributor

luser commented Dec 11, 2018

It looks like this needs to be rebased to latest master. Do one of you want to take care of that or should I do it?

@mystor
Copy link
Contributor Author

mystor commented Dec 11, 2018

If there's any chance you'd be willing to do that it would save me setting stuff up again :-)

@luser
Copy link
Contributor

luser commented Feb 8, 2019

I rebased this locally and pushed it to master:
06421ba

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants