Merge pull request #104 from pdehaan/clean-eslint

Fix a bunch of ESLint and HTMLLint errors

.eslintrc.yml

@@ -1,13 +1,11 @@
 env:
-  browser: true
   es6: true
-  jquery: true
-  mocha: true
   node: true
 
 extends:
   - eslint:recommended
   - plugin:node/recommended
+  - plugin:security/recommended
 
 plugins:
   - node
@@ -16,18 +14,10 @@ plugins:
 root: true
 
 rules:
-  security/detect-buffer-noassert: warn
-  security/detect-child-process: warn
-  security/detect-disable-mustache-escape: warn
-  security/detect-eval-with-expression: warn
-  security/detect-new-buffer: warn
-  security/detect-no-csrf-before-method-override: warn
-  security/detect-non-literal-fs-filename: warn
-  security/detect-non-literal-regexp: warn
-  security/detect-non-literal-require: warn
-  security/detect-possible-timing-attacks: warn
-  security/detect-pseudoRandomBytes: warn
-  security/detect-unsafe-regex: warn
+  node/no-unpublished-require: off
+
+  security/detect-non-literal-fs-filename: off
+  security/detect-object-injection: off
 
   eqeqeq: error
   no-console: warn

.stylelintrc

@@ -2,4 +2,5 @@ extends: stylelint-config-standard
 
 rules:
   color-hex-case: upper
+  declaration-colon-newline-after: null
   selector-list-comma-newline-after: null

circle.yml

@@ -9,3 +9,8 @@ deployment:
     - docker login -e $DOCKER_EMAIL -u $DOCKER_USER -p $DOCKER_PASS
     - docker build . -t mozilla/portal:latest
     - docker push mozilla/portal:latest
+
+test:
+  override:
+    - npm run lint
+    - npm test

frontend/src/.eslintrc.yml

@@ -0,0 +1,3 @@
+env:
+  browser: true
+  jquery: true

frontend/src/fileSender.js

@@ -1,5 +1,5 @@
 const EventEmitter = require('events');
-const { ivToStr, notify } = require('./utils');
+const { ivToStr } = require('./utils');
 
 class FileSender extends EventEmitter {
   constructor(file) {
@@ -23,7 +23,7 @@ class FileSender extends EventEmitter {
         }
 
         if (xhr.status === 200) {
-          console.log('The file was successfully deleted.')
+          console.log('The file was successfully deleted.');
         } else {
           console.log('The file has expired, or has already been deleted.');
         }

frontend/src/upload.js

@@ -1,5 +1,5 @@
 const FileSender = require('./fileSender');
-const { notify } = require('./utils')
+const { notify } = require('./utils');
 const $ = require('jquery');
 
 $(document).ready(function() {
@@ -15,7 +15,7 @@ $(document).ready(function() {
 
   // copy link to clipboard
   $copyBtn.click(() => {
-    var aux = document.createElement('input');
+    const aux = document.createElement('input');
     aux.setAttribute('value', $('#link').attr('value'));
     document.body.appendChild(aux);
     aux.select();
@@ -61,7 +61,6 @@ $(document).ready(function() {
     const popupDiv = document.createElement('div');
     const $popupText = $('<span>', { class: 'popuptext' });
     const cellText = document.createTextNode(file.name);
-    const progress = document.createElement('p');
 
     name.appendChild(cellText);
 

frontend/src/utils.js

@@ -21,15 +21,14 @@ function strToIv(str) {
 }
 
 function notify(str) {
-  if (!("Notification" in window)) {
+  if (!('Notification' in window)) {
     return;
   } else if (Notification.permission === 'granted') {
-    new Notification(str)
+    new Notification(str);
   } else if (Notification.permission !== 'denied') {
     Notification.requestPermission(function(permission) {
-      if (permission === 'granted')
-        new Notification(str);
-    })
+      if (permission === 'granted') new Notification(str);
+    });
   }
 }