Skip to content
This repository has been archived by the owner on May 22, 2021. It is now read-only.

Localization #57

Closed
dannycoates opened this issue Jun 7, 2017 · 11 comments
Closed

Localization #57

dannycoates opened this issue Jun 7, 2017 · 11 comments
Labels
Milestone

Comments

@dannycoates
Copy link
Contributor

???

@dannycoates dannycoates added this to the Elegant Eagle milestone Jun 20, 2017
@pdehaan
Copy link
Collaborator

pdehaan commented Jun 21, 2017

Here's how Firefox Notes is doin' it: mozilla/notes#96

Nevermind, they're a web-ext, we aren't.

@pdehaan pdehaan marked this as a duplicate of #113 Jul 18, 2017
@dannycoates
Copy link
Contributor Author

Added l20n in #245

@ghost
Copy link

ghost commented Jul 19, 2017

@flodolo This project is ready for adding to Pontoon we think

@ghost
Copy link

ghost commented Jul 19, 2017

https://github.com/mozilla/send/tree/master/public/locales is the directory. is that an ok location or does it need to be in the root?

@flodolo
Copy link
Collaborator

flodolo commented Jul 20, 2017

CC @mathjazz

I'm pretty sure locales doesn't need to be in the root, but that structure is wrong
https://developer.mozilla.org/en-US/docs/Mozilla/Implementing_Pontoon_in_a_Mozilla_website

en-US should be a folder, and disappear from the filename.

The whole file needs to be reviewed, and comments added. Not completely sure how to do that efficiently. Maybe remove the file completely, and open a PR with the correct structure and filename so I can comment?

Also, there are a ton more information I need before enabling a project in Pontoon:

  • Deadlines
  • Dev server and how to test
  • Is "Firefox Send" a brand name? Can it be localized?
  • Pontoon needs access to the repository

@flodolo
Copy link
Collaborator

flodolo commented Jul 20, 2017

Also cc @stasm and @Pike. A few notes from a quick look at the FTL file, to speed up the review later. As said, I think the easiest way is to remove the add the correct FTL in a pull request and use that to comment.

nit: use 4 spaces instead of 2 when indenting attributes.

Do you really need this?

uploadingPageCancel = Cancel upload
  .title = {uploadingPageCancel}

It should probably just be

uploadingPageCancel
    .title = Cancel upload
sentFilesTitle1 = File
sentFilesTitle2 = Copy URL
sentFilesTitle3 = Expires In
sentFilesTitle4 = Delete

These don't look like titles, let's find better string IDs.

This

deleteButtonHover.title = {sentFilesTitle4}

Should be

deleteButtonHover
    .title = Delete

Unless strictly necessarily, don't reuse strings like this.

@Pike
Copy link

Pike commented Jul 20, 2017

We'll also need a top-level l10n.toml file, similar to the one I've created for formautofill, mozilla-l10n/formautofill-l10n#1.

Also, for now please make sure that your file passes through https://github.com/projectfluent/python-fluent/blob/master/tools/fluentfmt.py, 'cause otherwise our toolchains can create weird and buggy output.

@abhinadduri
Copy link
Collaborator

@flodolo I will submit a PR with a revised file today.

@flodolo
Copy link
Collaborator

flodolo commented Jul 25, 2017

Here's the description that I've put in the Info section in Pontoon. I'm going to enable the project in a few minutes on prod (tested a commit on stage already).

Firefox Send is the first stand-alone web service distributed as part of Test Pilot: it's a website where you can upload a file and get a link to share it. Once the file has been downloaded, it gets removed from the server. Basically, a one-time, secure file sharing website that will work with any browser.

Let me know if you have amends.

@flodolo
Copy link
Collaborator

flodolo commented Jul 25, 2017

@dannycoates
Dev server doesn't seem to automatically update with localized content?
https://send.dev.mozaws.net/

@dannycoates
Copy link
Contributor Author

Yeah, we'll need to set different availableLanguages for dev. I'll file an issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants