Localization #245
Localization #245
Conversation
public/locales/send.en-US.ftl
Outdated
| uploadSuccessConfirmHeader = Ready to Send | ||
|
|
||
|
|
||
| //Notethe spec suggests that this string is editable. That feature will not appear at Launch |
There was a problem hiding this comment.
nit: add space between "Note" and "the"
views/download.handlebars
Outdated
| </div> | ||
| <div class="description" data-l10n-id="downloadMessage"></div> | ||
| <img src="/resources/illustration_download.svg" id="download-img" alt="Download"/> |
There was a problem hiding this comment.
Translate "Download" alt attribute?
views/download.handlebars
Outdated
| Your friend is sending you a file with Firefox Send, a service that allows you to share files with a safe, private, and encrypted link that automatically expires to ensure your stuff does not remain online forever. | ||
| <span id="dl-filename" | ||
| data-l10n-id="downloadFileName" | ||
| data-l10n-args='{"filename": "{{{filename}}}"}'></span> |
There was a problem hiding this comment.
use 2 braces for filename, {{filename}}
views/download.handlebars
Outdated
| </div> | ||
| <div class="description" data-l10n-id="downloadMessage"></div> | ||
| <img src="/resources/illustration_download.svg" id="download-img" alt="Download"/> |
There was a problem hiding this comment.
alt text should be localized too.
server/server.js
Outdated
| @@ -63,6 +65,9 @@ app.use( | |||
| app.use(busboy()); | |||
| app.use(bodyParser.json()); | |||
| app.use(express.static(STATIC_PATH)); | |||
| app.use('/l20n', express.static(L20N)); | |||
| app.use('/download/*/l20n', express.static(L20N)); | |||
| app.use('/download/*/locales', express.static(LOCALES)); | |||
There was a problem hiding this comment.
why do we need routes relative to /download?
There was a problem hiding this comment.
The express app doesn't recognize the static route if you don't explicitly add routes with respect to /download.
views/download.handlebars
Outdated
| <div class="title"> | ||
| This link has expired or never existed in the first place. | ||
| </div> | ||
| <div class="title" data-l10n-id="expiredPageHeader"></div> | ||
|
|
||
| <div class="share-window"> | ||
| <img src="/resources/illustration_expired.svg" id="expired-img" alt="Link expired" /> |
| @@ -47,8 +47,11 @@ $(document).ready(function() { | |||
| //on complete | |||
There was a problem hiding this comment.
Disclaimer: I have zero idea what I'm talking about, but I'd assume that the filesizes may need to be localized as well. For example, up on lines 34-45 above where we say "23KB", or "199MB", or "1.5GB".
views/index.handlebars
Outdated
| <a id="dl-firefox" href="https://www.mozilla.org/firefox/new/?scene=2" target="_blank"> | ||
| <img src="/resources/firefox_logo-only.svg" id="firefox-logo" alt="Firefox"/> | ||
| <div id="dl-firefox-text">Firefox<br><span>Free Download</span></div> | ||
| <div id="dl-firefox-text">Firefox<br> |
There was a problem hiding this comment.
Does "Firefox" need to be translated here?
views/layouts/main.handlebars
Outdated
| <meta name="defaultLanguage" content="en-US"> | ||
| <meta name="availableLanguages" content="en-US"> | ||
| <link rel="localization" href="locales/send.{locale}.ftl"> | ||
| <script defer src="/l20n/dist/web/l20n.js"></script> |
There was a problem hiding this comment.
Does this handle rtl languages, or will we need to add special CSS somewhere?
views/layouts/main.handlebars
Outdated
|
|
||
| <meta name="defaultLanguage" content="en-US"> | ||
| <meta name="availableLanguages" content="en-US"> | ||
| <link rel="localization" href="locales/send.{locale}.ftl"> |
There was a problem hiding this comment.
nit: leading / on /locales/... to be consistent with other absolute asset URLs.
|
Also, now that we have /public/resources/send_logo_type.svg, do we need to have locale specific versions of that? |
I will fix merge conflicts after final review.