This repository has been archived by the owner on May 22, 2021. It is now read-only.
added Dockerfile #103
Merged
added Dockerfile #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@relud how's this Dockerfile? |
relud
suggested changes
Jun 20, 2017
Dockerfile
Outdated
| RUN mkdir static | ||
| RUN npm install | ||
|
|
||
| EXPOSE 1443 |
There was a problem hiding this comment.
You should ENV PORT=1443 and EXPOSE $PORT, and the app should accept a PORT env variable to listen on. This is because cloudops deploys docker containers with --net host, so PORT must be configurable.
.circleci/circle.yml
Outdated
| - .node_modules | ||
| - run: | ||
| name: test | ||
| command: npm test |
There was a problem hiding this comment.
you should add a deploy step to circleci that builds the docker image and uploads it, like this:
deployment:
latest:
branch: master
commands:
- docker login -e $DOCKER_EMAIL -u $DOCKER_USER -p $DOCKER_PASS
- docker build . -t mozilla/portal:latest
- docker push mozilla/portal:latest
I will add the needed env vars in circle when this is ready
relud
suggested changes
Jun 20, 2017
Dockerfile
Outdated
| RUN npm install | ||
|
|
||
| ENV P2P_LISTEN_PORT=1443 | ||
| EXPOSE $P2P_LISTEN_PORT |
There was a problem hiding this comment.
The standard name for this variable is 'PORT'
dannycoates
force-pushed
the
docker
branch
2 times, most recently
from
208f9f2
to
4508920
Compare
relud
reviewed
Jun 20, 2017
docs/docker.md
Outdated
|
|
||
| Example | ||
|
|
||
| docker run --net=host -e 'NODE_ENV=production' -e 'P2P_S3_BUCKET=testpilot-p2p-dev' -e 'P2P_REDIS_HOST=dyf9s2r4vo3.bolxr4.0001.usw2.cache.amazonaws.com' |
There was a problem hiding this comment.
this command should probably end with an image name, like mozilla/portal:latest
relud
approved these changes
Jun 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #67