This repository has been archived by the owner on May 22, 2021. It is now read-only.
add footer #222
Merged
add footer #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericawright
approved these changes
Jul 18, 2017
pdehaan
reviewed
Jul 18, 2017
| <!-- Generator: Adobe Illustrator 16.0.0, SVG Export Plug-In . SVG Version: 6.00 Build 0) --> | ||
| <!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd"> | ||
| <svg version="1.1" id="Capa_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px" | ||
| width="438.549px" height="438.549px" viewBox="0 0 438.549 438.549" style="enable-background:new 0 0 438.549 438.549;" |
There was a problem hiding this comment.
Will this style="" attribute cause issues too?
There was a problem hiding this comment.
not visibly so far, but good question
pdehaan
reviewed
Jul 18, 2017
| <a href="https://twitter.com/FxTestPilot" target="_blank"><img class="twitter" src="/resources/twitter-icon.svg"/></a> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Me thinks that this would push the footer outside of the <html> tag. I'll file a new bug shortly.
</div>
</div>
</body>
</html>
<div class="footer">
<div class="legal-links">
<a href="https://www.mozilla.org"><img class="mozilla-logo" src="/resources/mozilla-logo.svg"/></a>
<a href="https://www.mozilla.org/about/legal/">Legal</a>
<a href="https://testpilot.firefox.com/about">About Test Pilot</a>
<a href="https://testpilot.firefox.com/privacy">Privacy</a>
<a href="https://testpilot.firefox.com/terms">Terms</a>
<a href="https://www.mozilla.org/en-US/privacy/websites/#cookies">Cookies</a>
</div>
<div class="social-links">
<a href="https://github.com/mozilla/testpilot" target="_blank"><img class="github" src="/resources/github-icon.svg"/></a>
<a href="https://twitter.com/FxTestPilot" target="_blank"><img class="twitter" src="/resources/twitter-icon.svg"/></a>
</div>
</div>UPDATE: Filed as #230
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #207