This repository has been archived by the owner on May 22, 2021. It is now read-only.
Changed naming for some pages, no longer stores files by name on server #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannycoates
suggested changes
May 30, 2017
app.js
Outdated
|
|
||
| res.download(__dirname + '/static/' + reply); | ||
| client.del(id); | ||
| res.download(__dirname + '/static/' + id, reply); |
There was a problem hiding this comment.
Let's move the client.del(id) into the callback of download. We'll get an error there if something went wrong, and at that point we can also delete the file off the disk.
Something like:
res.download(__dirname + '/static/' + id, reply, function (err) {
if (!err) {
client.del(id)
fs.unlinkSync(__dirname + '/static/' + id)
}
// log the error
})
app.js
Outdated
| @@ -26,12 +26,12 @@ app.get('/assets/download/:id', function(req, res) { | |||
| let id = req.params.id; | |||
| client.hget(id, "filename", function(err, reply) { // maybe some expiration logic too | |||
| if (!reply) { | |||
| res.send('error'); | |||
| res.send('This link has expired!'); | |||
There was a problem hiding this comment.
We should return a 404 in this case.
dannycoates
approved these changes
May 31, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.