added messages for processing phases #285
Conversation
|
This looks "funny" to my untrained eye:
Not sure if we want to hide the entire progress area when the download is complete (unless that looks too janky): <div class="progress-bar" id="dl-progress">
<div class="percentage">
<span class="percent-number"></span>
<span class="percent-sign">%</span>
</div>
</div> |
|
Apart from my one nit, looks good to me. Great riff! |
yeah. It's less funny with the 100% intact. |
frontend/src/upload.js
Outdated
| // For large files we need to give the ui a tick to breathe and update | ||
| // before we kick off the FileSender | ||
| setTimeout(() => { | ||
| //don't allow drag and drop when not on page-one |
There was a problem hiding this comment.
can you put this comment back with the code it belongs to:
$('body').off('drop', onUpload); line 166
|
I think I'd like it to start with the 0% in the center of the circle even when the other stages are being done. |
fixed |
| const totalTime = endTime - startTime; | ||
| const uploadTime = endTime - uploadStart; | ||
| const uploadSpeed = file.size / (uploadTime / 1000); | ||
| const expiration = 24 * 60 * 60 * 1000; //will eventually come from a field |
There was a problem hiding this comment.
Unrelated, but not sure if this can be replaced with the ONE_DAY_IN_MS const imported above.
|
Looks good! |
A riff on #282. Thanks @pdehaan!
fixes #128
fixes #273
fixes #277
The main difference is the addition of the
setTimeoutto allow the upload-progress panel to show faster.